Remove or tag uses of SR and symbolic functions in combinat, categories, etc.

[mkoeppe]

Follow-up on #32411.

Use of floor/ceil from sage.functions can be avoided.

Modules that only need symbolics in some methods should avoid module-level imports from sage.functions, sage.symbolic, sage.calculus.

Doctests that need these modules should be marked # optional - sage.symbolic.

This can be tested using #32601 (sagemath-standard-no-symbolics)

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 4a1b489

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/32609

[mkoeppe]

Branch: u/mkoeppe/remove_more_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_combinat

[mkoeppe]

Commit: 04855a1

[mkoeppe]

New commits:

6bd6903	PowerSeriesRing_generic._element_constructor_: Only import sage.symbolic.expression.SymbolicSeries after isinstance test with ABC Expression
9730b10	src/sage/categories/metric_spaces.py: Mark doctests using HyperbolicPlane # optional - sage.symbolic
dca7113	In doctests, replace floor(.../...) by //
44ac5ab	src/sage/categories/vector_bundles.py: Mark doctests # optional - sage.symbolic
71303dd	src/sage/matrix/operation_table.py: Use math.log, log10 insteadd of importing from sage.misc.functional
04855a1	src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x)

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,31 +2,9 @@
 
 Use of `floor`/`ceil` from `sage.functions` can be avoided.
 
-Modules that only need symbolics in some methods should avoid module-level imports from `sage.functions`, `sage.symbolic`, `sage.calculus`
+Modules that only need symbolics in some methods should avoid module-level imports from `sage.functions`, `sage.symbolic`, `sage.calculus`.
 
-```
-src/sage/categories/loop_crystals.py:from sage.functions.other import ceil
-src/sage/combinat/binary_recurrence_sequences.py:from sage.functions.log import log
-src/sage/combinat/binary_recurrence_sequences.py:from sage.functions.other import sqrt
-src/sage/combinat/crystals/littelmann_path.py:from sage.functions.other import floor
-src/sage/combinat/crystals/tensor_product.py:from sage.functions.other import floor, ceil
-src/sage/combinat/crystals/tensor_product_element.pyx:from sage.functions.other import ceil
-src/sage/combinat/diagram_algebras.py:from sage.functions.other import floor, ceil
-src/sage/combinat/finite_state_machine.py:from sage.calculus.var import var
-src/sage/combinat/finite_state_machine.py:from sage.functions.trig import atan2
-src/sage/combinat/k_tableau.py:from sage.functions.generalized import sgn
-src/sage/combinat/parallelogram_polyomino.py:from sage.functions.trig import cos, sin
-src/sage/combinat/parallelogram_polyomino.py:from sage.functions.other import sqrt
-src/sage/combinat/partition.py:from sage.symbolic.ring import var
-src/sage/combinat/partition_algebra.py:from sage.functions.all import ceil
-src/sage/combinat/root_system/coxeter_type.py:from sage.symbolic.ring import SR
-src/sage/combinat/sine_gordon.py:from sage.functions.trig import cos, sin
-src/sage/combinat/sine_gordon.py:from sage.symbolic.constants import pi, I
-src/sage/combinat/sine_gordon.py:from sage.functions.log import exp
-src/sage/combinat/sine_gordon.py:from sage.functions.other import ceil
-src/sage/combinat/sine_gordon.py:from sage.symbolic.ring import SR
-src/sage/combinat/sine_gordon.py:from sage.functions.other import real_part, imag_part
-src/sage/combinat/sloane_functions.py:from sage.functions.all import prime_pi
-src/sage/combinat/symmetric_group_representations.py:from sage.symbolic.ring import SR
-src/sage/combinat/symmetric_group_representations.py:from sage.functions.all import sqrt
-```
+Doctests that need these modules should be marked `# optional - sage.symbolic`.
+
+This can be tested using #32601 (**sagemath-standard-no-symbolics**)
+

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Changed commit from 04855a1 to ecad015

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ecad015

src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x) (fixup)

[sagetrac-git]

Changed commit from ecad015 to 2511e3e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5d2cc6b	PowerSeriesRing_generic._element_constructor_: Only import sage.symbolic.expression.SymbolicSeries after isinstance test with ABC Expression
dc8cc8c	src/sage/categories/metric_spaces.py: Mark doctests using HyperbolicPlane # optional - sage.symbolic
9ca27e7	In doctests, replace floor(.../...) by //
444b659	src/sage/categories/vector_bundles.py: Mark doctests # optional - sage.symbolic
63b0ad8	src/sage/matrix/operation_table.py: Use math.log, log10 insteadd of importing from sage.misc.functional
13c5092	src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x)
2511e3e	src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x) (fixup)

[sagetrac-git]

Changed commit from 2511e3e to ea8d379

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e3b36fa	src/sage/categories/algebra_functor.py: Make doctests using sqrt # optional - sage.symbolic
ea8d379	src/sage/categories/rings.py: Mark doctests using sqrt # optional - sage.symbolic

[sagetrac-git]

Changed commit from ea8d379 to 9cae6cb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c7bd9ad	src/sage/arith/multi_modular.pyx: Use primecountpy.primecount directly instead of going through sage.functions
9cae6cb	src/sage/groups/semimonomial_transformations/semimonomial_transformation_group.py: Import factorial from sage.arith.misc

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

994f47b	src/sage/categories/number_fields.py: Remove abuse of predefined x in doctests
4a1fc16	src/sage/structure/element.pyx: Remove abuse of predefined x in doctests
c6714aa	src/sage/categories/coxeter_groups.py: Mark a doctest # optional - sage.symbolic
30fa675	src/sage/categories/pushout.py: Remove abuse of predefined x in doctests
3cd7195	src/sage/categories/modules_with_basis.py: In doctest, import factorial from sage.arith.misc

[sagetrac-git]

Changed commit from 9cae6cb to 3cd7195