RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint

[mkoeppe]

is_included_in is only defined by RealSet. We deprecate it and replace it by is_subset.

The spelling issubset is used in Python sets. is_subset is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that issubset "should be deprecated".

Depends on #21243

CC: @tscrim @mjungmath

Component: geometry

Author: Matthias Koeppe

Branch/Commit: f27026f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31927

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 `is_included_in` is only defined by `RealSet`. We deprecate it and replace it by `is_subset`.
 
-The spelling `issubset` is used in Python sets. `is_subset` is widely used in Sage. Sympy provides both spellings (see #31926)
+The spelling `issubset` is used in Python sets. `is_subset` is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that `issubset` "should be deprecated".
 
 For symmetry, we also introduce `is_superset`/`issuperset` etc.
 

[mkoeppe]

Branch: u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset

[mkoeppe]

Commit: 9079a10

[mkoeppe]

New commits:

9079a10

RealSet.is_subset: Rename from is_included_in

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,5 +2,4 @@
 
 The spelling `issubset` is used in Python sets. `is_subset` is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that `issubset` "should be deprecated".
 
-For symmetry, we also introduce `is_superset`/`issuperset` etc.
 

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5b8ceca	InternalRealInterval, RealSet: Add `_latex_` methods
69ca854	RealSet._repr_: Use unicode cup sign instead of +
dbdfc06	InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation
a0e3bf5	Merge #31880
181b128	RealSet.is_open, is_closed, closure, interior, boundary: New
7f56338	PiecewiseFunction: Adjust doctests for changed RealSet repr
8cd74b5	Merge #31880
8fdb104	RealSet.boundary: Add another doctest
0a2f499	Merge #21243
4bc5a2c	RealSet.is_disjoint: Rename from is_disjoint_from

[sagetrac-git]

Changed commit from 9079a10 to 4bc5a2c

[mkoeppe]

Dependencies: #21243

[tscrim]

comment:8

LGTM.

Can you also open a followup ticket (or on the original tickets or here) some quick fixes of some little things I missed during my previous reviews (sorry!):

• RealSet, InternalRealInterval: Improve _repr_ and add _latex_ method #31880 Add # -*- coding: utf-8 -*- to the top of piecewise.py.
• RealSet: add methods closure, interior, boundary, is_open, is_closed #21243 Remove the itertools import.

[tscrim]

Reviewer: Travis Scrimshaw

[mkoeppe]

comment:9

Thanks! I have updated these tickets.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9d41f0e	src/sage/sets/real_set.py: Remove unnecessary import
f27026f	Merge #21243