ManifoldSubset.difference, complement

[mkoeppe]

We implement ManifoldSubset.difference by making a new subset and declaring a disjoint union (#31764)

Depends on #31764

CC: @egourgoulhon @mjungmath

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: 2113f78

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/31798

[mkoeppe]

Branch: u/mkoeppe/manifoldsubset_difference__complement

[mkoeppe]

Commit: 3786cee

[mkoeppe]

Last 10 new commits:

0032bf9	ManifoldSubset.intersection: Go through ManifoldSubsetFiniteFamily to make the order of operations canonical
282010b	ManifoldSubset._union_subset: Factor out from ManifoldSubset.union
6772570	ManifoldSubset.union: Handle arbitrary unions
edfea33	ManifoldSubset.union: Add example and plots
fdd0aba	ManifoldSubset.declare_union: Handle arbitrary unions
c2f484c	src/sage/manifolds/subset.py: import itertools
a083569	ManifoldSubset._intersection_subset, _union_subset: Use declare_subset, declare_superset; fix doctest
da91653	ManifoldSubset._union_subset: Fixup
3e6a9cf	Merge #31764
3786cee	ManifoldSubset.difference, complement: New

[mjungmath]

comment:3

Patchbot seems not to like it.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6370e88

ManifoldSubset.difference, complement: New

[sagetrac-git]

Changed commit from 3786cee to 6370e88

[mkoeppe]

comment:5

Let's see what the patchbot thinks now

[egourgoulhon]

comment:6

Replying to @mkoeppe:

Let's see what the patchbot thinks now

He's still not happy, but this seems due to the lack of coverage in the dependency #31764.

[egourgoulhon]

comment:7

Btw, with Python 3, shouldn't the non_ascii plugin be removed from the pathbot? It generates a false alarm here.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

94edd68	ManifoldSubset.declare_superset: Fix documentation
41826b4	ManifoldSubset.declare_{sub,super}set: Expand docstring
3ef5141	Merge #31763
79a625b	ManifoldSubset._reduce_intersection_members: Add examples, raise TypeError if input is empty family
8e70023	ManifoldSubset._reduce_union_members: Add examples
ee4efc9	ManifoldSubset._{union,intersection}_subset: Do cache the result here; add examples
e7f7a7d	Merge #31764

[sagetrac-git]

Changed commit from 6370e88 to e7f7a7d

[sagetrac-git]

Changed commit from e7f7a7d to 8d3ad85

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

21739de	src/sage/manifolds/subset.py: Simplify code, make pyflakes happy
6bbd4ae	src/sage/manifolds/subset.py: Add coding header
2d7fda7	src/sage/manifolds/subset.py: Simplify code more to make pyflakes happy
8d3ad85	Merge #31764