build/make/Makefile.in: For script packages without spkg-install, run "sage -info" and exit with error

[mkoeppe]

Then scripts like build/pkgs/perl_cpan_polymake_prereq/spkg-install can be removed.

This will help toward #31522 - because the GH Actions scripts can just avoid trying to install these packages.

CC: @kliem @jhpalmieri @slel

Component: build

Author: Matthias Koeppe

Branch/Commit: c1bf356

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/31163

[mkoeppe]

comment:1

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
 Then scripts like `build/pkgs/perl_cpan_polymake_prereq/spkg-install` can be removed.
 
+This will help toward #31522 - because the GH Actions scripts can just avoid trying to install these packages.
+

[mkoeppe]

Branch: u/mkoeppe/build_make_makefile_in__for_script_packages_without_spkg_install__run__sage__info__and_exit_with_error

[mkoeppe]

Commit: 8f782c0

[mkoeppe]

New commits:

2576f86	build/make/Makefile.in: If a script package has no spkg-install, run "sage -info" and exit with error
feb8de7	build/pkgs/: Remove spkg-install scripts for dummy script packages
8f782c0	.github/workflows/tox-{optional,experimental}.yml: Do not try to test dummy script packages

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Reviewer: https://github.com/sagemath/sagetrac-mirror/actions/runs/1249185115

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4b292be	build/pkgs/perl_mongodb/spkg-install: Remove
a7b6352	build/bin/sage-spkg-info: Fix display of system packages

[sagetrac-git]

Changed commit from 8f782c0 to a7b6352

[mkoeppe]

comment:9

Comparing https://github.com/sagemath/sagetrac-mirror/actions/runs/1249185115 with https://github.com/sagemath/sage/actions/runs/1231575049 shows much fewer "ERROR IN LOG FILE" annotations.

Ready for review

[jhpalmieri]

comment:10

A small issue: running ./sage -i graphviz prints this at the end:

The following package(s) may have failed to build (not necessarily
during this run of 'make graphviz'):

It is safe to delete any log files and build directories, but they
contain information that is helpful for debugging build problems.
WARNING: If you now run 'make' again, the build directory of the
same version of the package will, by default, be deleted. Set the
environment variable SAGE_KEEP_BUILT_SPKGS=yes to prevent this.

Should sage --info ... also write the output to a log file with an appropriate error so that it gets flagged in this message?

[mkoeppe]

comment:11

I don't think this would be very useful. The output already goes to logs/install.log

[jhpalmieri]

comment:12

Also, and I'm guessing this is beyond the scope of this ticket, but on my Mac I did brew install graphviz and then ./configure, and it said

configure:43560: result: graphviz-none:                               using system package; SPKG will not be installed

It would be nice if make graphviz said that it was already installed as a system package, rather than giving the same error message as if it weren't installed.

[sagetrac-git]

Changed commit from a7b6352 to e65b309

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e65b309

bootstrap: Do not provide ./configure --enable-SPKG options for dummy optional packages