Meta-ticket: Downstream patch upstreaming

[mkoeppe]

https://wiki.sagemath.org/days111

• Arch: https://aur.archlinux.org/cgit/aur.git/tree/?h=sagemath-git

• Gentoo: https://github.com/cschwan/sage-on-gentoo/tree/master/sci-mathematics/sage

• Debian: https://salsa.debian.org/math-team/sagemath/tree/master/debian/patches

• macOS: https://github.com/3-manifolds/Sage_macOS/tree/main/Sage_framework

• void linux: https://github.com/void-linux/void-packages/tree/master/srcpkgs/sagemath

See also: https://wiki.sagemath.org/Distribution

Issues:

• Set environment for sage.misc.cython #31041: sage.misc.cython -- libdir (gentoo)
• some raw string for pdf doc building in sage-on-gentoo #31032: some raw strings for pdf docbuilding (gentoo)
• Install COPYING.txt #21571: install COPYING.txt with documentation and find it there (gentoo)
• Install tests in sage/tests/books #31037: Install missing tests (Arch)

cp -r sage/tests/books "$pkgdir"/$_pythonpath/sage/tests

• Make latte program prefix (or just "count" program name) configurable
• System package information and spkg-configure for mathjax #30296: mathjax
• cython_aliases: Do not fail if one of the listed libraries is not known to pkgconfig #31384: cython_aliases

CC: @tobihan @antonio-rojas @kiwifb @orlitzky @isuruf @jamesjer @slel @tornaria @culler

Component: porting

Keywords: sd111

Issue created by migration from https://trac.sagemath.org/ticket/31016

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,2 +1,13 @@
 https://wiki.sagemath.org/days111
 
+- Arch: https://aur.archlinux.org/cgit/aur.git/tree/?h=sagemath-git
+
+- Gentoo: https://github.com/cschwan/sage-on-gentoo/tree/master/sci-mathematics/sage
+
+
+
+Issues:
+
+- sage.misc.cython -- libdir (gentoo)
+
+

[mkoeppe]

Description changed:

--- 
+++ 
@@ -4,6 +4,7 @@
 
 - Gentoo: https://github.com/cschwan/sage-on-gentoo/tree/master/sci-mathematics/sage
 
+- Debian: https://sources.debian.org/patches/sagemath/9.2-2/
 
 
 Issues:

[mkoeppe]

Description changed:

--- 
+++ 
@@ -4,11 +4,15 @@
 
 - Gentoo: https://github.com/cschwan/sage-on-gentoo/tree/master/sci-mathematics/sage
 
-- Debian: https://sources.debian.org/patches/sagemath/9.2-2/
 
 
 Issues:
 
 - sage.misc.cython -- libdir (gentoo)
 
+- # Install tests
 
+```
+  cp -r sage/doctest/tests "$pkgdir"/$_pythonpath/sage/doctest
+  cp -r sage/tests/books "$pkgdir"/$_pythonpath/sage/tests
+```

[mkoeppe]

Description changed:

--- 
+++ 
@@ -16,3 +16,7 @@
   cp -r sage/doctest/tests "$pkgdir"/$_pythonpath/sage/doctest
   cp -r sage/tests/books "$pkgdir"/$_pythonpath/sage/tests
 ```
+
+- Make latte program prefix (or just "count" program name) configurable
+
+

[mkoeppe]

Description changed:

--- 
+++ 
@@ -4,7 +4,7 @@
 
 - Gentoo: https://github.com/cschwan/sage-on-gentoo/tree/master/sci-mathematics/sage
 
-
+- Debian: https://sources.debian.org/patches/sagemath/9.2-2/
 
 Issues:
 

[kiwifb]

Description changed:

--- 
+++ 
@@ -9,6 +9,8 @@
 Issues:
 
 - sage.misc.cython -- libdir (gentoo)
+- some raw strings for pdf docbuilding (gentoo)
+- install `COPYING.txt` with documentation and find it there (gentoo)
 
 - # Install tests
 

[mkoeppe]

Description changed:

--- 
+++ 
@@ -21,4 +21,4 @@
 
 - Make latte program prefix (or just "count" program name) configurable
 
-
+- mathjax (see #30296)

[kiwifb]

Description changed:

--- 
+++ 
@@ -9,7 +9,7 @@
 Issues:
 
 - sage.misc.cython -- libdir (gentoo)
-- some raw strings for pdf docbuilding (gentoo)
+- some raw strings for pdf docbuilding (gentoo) #31032
 - install `COPYING.txt` with documentation and find it there (gentoo)
 
 - # Install tests

[kiwifb]

comment:8

Should I add my language selection options for building the documentation?

[tobihan]

comment:9

Some of the reasons we still run configure and make to build the Debian package:

• In order to run the tests during package build we need a working sage (without installing it into the system).
• We are still installing var/libs/sage/installed since it is (or at least used to be) needed to detect which optional packages are installed.
• It is hard to keep track how to build the parts other than sagelib separately (doc, jupyter kernel...) and to set everything up for running the tests before system installation.

Will #29013 and ./configure --with-python=no help with these problems? Will there also be a make install for the non-python parts of sage?

[mkoeppe]

comment:10

Replying to @tobihan:

Some of the reasons we still run configure and make to build the Debian package:

• In order to run the tests during package build we need a working sage (without installing it into the system).
• We are still installing var/libs/sage/installed since it is (or at least used to be) needed to detect which optional packages are installed.
• It is hard to keep track how to build the parts other than sagelib separately (doc, jupyter kernel...) and to set everything up for running the tests before system installation.

These are of course all valid points. The second point will hopefully be resolved soon in the course of the modularization, as the build will no longer depend on the presence of optional libraries.

I hope we can resolve the third point soon. For example, I hope that we can put the docbuild into a separate Python package - that's #29868.

Will #29013 and ./configure --with-python=no help with these problems?

Yes, I think it would offer a good route of transition for Debian packaging of Sage. With ./configure --with-python=no, which would imply ./configure --with-sage-venv=no (#30896), plain make would just install the non-Python parts of sage.

You could then install the Python library of sage following the standard way how you package Python packages in Debian.

[mkoeppe]

Description changed:

--- 
+++ 
@@ -5,6 +5,8 @@
 - Gentoo: https://github.com/cschwan/sage-on-gentoo/tree/master/sci-mathematics/sage
 
 - Debian: https://sources.debian.org/patches/sagemath/9.2-2/
+
+See also: https://wiki.sagemath.org/Distribution
 
 Issues:
 

[kiwifb]

comment:12

After double checking we already fixed the installation of text files. It looks like you may have been looking at an old ebuild. If not, that's something that should be updated to be current on my side.

[kiwifb]

Description changed:

--- 
+++ 
@@ -14,13 +14,6 @@
 - some raw strings for pdf docbuilding (gentoo) #31032
 - install `COPYING.txt` with documentation and find it there (gentoo)
 
-- # Install tests
-
-```
-  cp -r sage/doctest/tests "$pkgdir"/$_pythonpath/sage/doctest
-  cp -r sage/tests/books "$pkgdir"/$_pythonpath/sage/tests
-```
-
 - Make latte program prefix (or just "count" program name) configurable
 
 - mathjax (see #30296)

[antonio-rojas]

comment:13

Replying to @kiwifb:

After double checking we already fixed the installation of text files. It looks like you may have been looking at an old ebuild. If not, that's something that should be updated to be current on my side.

Those lines came from the Arch PKGBUILD. Indeed it looks like doctest/tests is already being installed by setup.py, but tests/books is not.