Fix gap_packages for Xcode 12

[mkoeppe]

Follow-up from #30720. Building gap_packages (version 4.10.2) using Xcode 12 fails:

gcc -c -O -fno-builtin gpd.c 
gpd.c:37:7: error: implicit declaration of function 'gpprog' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  if (gpprog()== -1) exit(1);
      ^
1 error generated.

Depends on #30720

Upstream: Reported upstream. No feedback yet.

CC: @dimpase @jhpalmieri @soehms

Component: packages: optional

Author: Matthias Koeppe, John Palmieri

Branch/Commit: d8f07f9

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30729

[mkoeppe]

Dependencies: #30720

[dimpase]

comment:2

I've opened gap-packages/cohomolo#27

[dimpase]

Upstream: Reported upstream. No feedback yet.

[mkoeppe]

comment:3

Was the update ticket #29314 successfully tested on Xcode 12?

[dimpase]

comment:4

it might be I didn't test the whole of gap_packages. I thought I did.

[jhpalmieri]

comment:5

I don't think #29314 upgrades gap_packages, but the new gap and libsemigroups build for me.

[mkoeppe]

comment:6

Replying to @jhpalmieri:

I don't think #29314 upgrades gap_packages

It does because it uses the same tarball as gap, via symlinks in build/pkgs/gap_packages

[mkoeppe]

comment:7

As suggested in #29314, patching the failing packages using the diff to the GAP 4.11 distribution would be a way forward.

[mkoeppe]

Reviewer: https://github.com/mkoeppe/sage/actions/runs/289319582

[mkoeppe]

comment:9

The failure is now also reproduced on GH Actions in local-homebrew-usrlocal-macos-maximal-xcode12, https://github.com/mkoeppe/sage/runs/1208931537

[mkoeppe]

Branch: u/mkoeppe/fix_gap_packages_for_xcode_12

[jhpalmieri]

Commit: 8693dc7

[jhpalmieri]

comment:11

I see the same error with this branch.

---

New commits:

c26eb00	fix cohomolo pkg code to allow build with gcc10
102946d	build/pkgs/gap_packages/patches/cohomolo-gcc10.patch: Backport
2c30b34	clang 12 (macOS XCode 12) needs extra includes
f89dc20	build/pkgs/gap_packages/patches/guava_leon_includes.patch: Backport
1b62f42	Merge branch 'u/mkoeppe/fix_gap_packages_for_gcc_10__xcode_12' of git://trac.sagemath.org/sage into t/30729/fix_gap_packages_for_xcode_12
a98639e	.github/workflows/tox.yml: Test homebrew-usrlocal in addition to homebrew
8693dc7	.github/workflows/tox-{optional,experimental}.yml: Test homebrew-usrlocal instead of homebrew

[jhpalmieri]

Description changed:

--- 
+++ 
@@ -1 +1,9 @@
-Follow-up from #30720
+Follow-up from #30720. Building `gap_packages` (version 4.10.2) using Xcode 12 fails:
+
+```
+gcc -c -O -fno-builtin gpd.c 
+gpd.c:37:7: error: implicit declaration of function 'gpprog' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
+  if (gpprog()== -1) exit(1);
+      ^
+1 error generated.
+```

[dimpase]

comment:12

Replying to @jhpalmieri:

I see the same error with this branch.

in GAP 4.10 the cohomolo's Makefile.in does not have a line

EXTRA_CFLAGS += -Wno-implicit-function-declaration

which is present in GAP 4.11 - so probably the quickest patch would be to add it in GAP 4.10.
(I started on fixing the code itself, but it's a nontrivial amount of changes).