Use configuration variable MAXIMA instead of hardcoding "maxima"

[mkoeppe]

Continuation of #29038.

Upstreaming a generalized version of
https://salsa.debian.org/science-team/sagemath/-/blob/master/debian/patches/d0-maxima.patch

CC: @tobihan @orlitzky @kiwifb

Component: build: configure

Author: François Bissey

Branch: 3da851f

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30563

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
+Continuation of #29038.
+
 Upstreaming a generalized version of 
 https://salsa.debian.org/science-team/sagemath/-/blob/master/debian/patches/d0-maxima.patch
 

[kiwifb]

comment:3

I am guessing that ideally we want to use the variable MAXIMA rather than those maxima and maxima-sage from the patch. It could be interesting as I could replace

	# run maxima with ecl
	sed -i "s:'maxima :'maxima -l ecl :g" \
		sage/interfaces/maxima.py \
		sage/interfaces/maxima_abstract.py

with a variable assignment in sage-on-gentoo.

[mkoeppe]

comment:4

Replying to @kiwifb:

I am guessing that ideally we want to use the variable MAXIMA

Yes, that's the idea

[kiwifb]

comment:5

maxima.py is already using MAXIMA that leaves us with touching maxima_abstract.py and a couple of things to help sage-on-debian pass its doctests out of the box.

Not sure how to proceed with bin/sage as it is not reading that configuration file, nor should it.

[mkoeppe]

comment:6

Replying to @kiwifb:

Not sure how to proceed with bin/sage as it is not reading that configuration file, nor should it.

sage-config MAXIMA works if sage_conf is installed, can fall back to maxima

[kiwifb]

comment:7

Replying to @mkoeppe:

Replying to @kiwifb:

Not sure how to proceed with bin/sage as it is not reading that configuration file, nor should it.

sage-config MAXIMA works if sage_conf is installed, can fall back to maxima

OK, that's another issue, I don't like how sage-config is installed as a separate package but this is kind of orthogonal.

[mkoeppe]

comment:8

Replying to @kiwifb:

I don't like how sage-config is installed as a separate package but this is kind of orthogonal.

Yes, that's orthogonal.

[kiwifb]

Commit: 3801013

[kiwifb]

Branch: u/fbissey/ticket_30563

[kiwifb]

comment:9

I shouldn't just leave things sitting on my hard drive.

There is a couple more things to do before calling it done.

---

New commits:

3801013

use the MAXIMA variable in maxima_abstract

[sagetrac-git]

Changed commit from 3801013 to 1ce58a7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1ce58a7

Relax some doctesting of string outputs for sage-on-debian

[sagetrac-git]

Changed commit from 1ce58a7 to 10bafa6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

10bafa6

use sage-config to figure maxima in bin/sage

[kiwifb]

comment:12

@mkoeppe was the last commit the kind of things you had in mind for src/bin/sage?