Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg

[mkoeppe]

#29766, #29441, and #29497 introduce build dependencies for packages that are only active when SAGE_CHECK is not no.

But whether a package needs its check-dependencies depends on both SAGE_CHECK_PACKAGES and SAGE_CHECK.

In this ticket, we move the handling of SAGE_CHECK_PACKAGES from sage-spkg to the Makefile.

This allows packages to conditionalize dependencies based on the new makefile variables SAGE_CHECK_symengine_py (for #29497) etc.

CC: @jhpalmieri @orlitzky @kliem @kiwifb

Component: build

Author: Matthias Koeppe

Branch/Commit: 5d13238

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30118

[mkoeppe]

Branch: u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

[mkoeppe]

New commits:

25393b0

Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-#29766 and #29497 introduce build dependencies for packages that are only active when `SAGE_CHECK` is not `no`.
+#29766, #29441, and #29497 introduce build dependencies for packages that are only active when `SAGE_CHECK` is not `no`.
 
 But whether a package needs its check-dependencies depends on both `SAGE_CHECK_PACKAGES` and `SAGE_CHECK`.
 

[mkoeppe]

Commit: 25393b0

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Description changed:

--- 
+++ 
@@ -4,4 +4,6 @@
 
 In this ticket, we move the handling of `SAGE_CHECK_PACKAGES` from `sage-spkg` to the Makefile. 
 
+This allows packages to conditionalize dependencies based on the new makefile variables `SAGE_CHECK_symengine_py` (for #29497) etc. 
 
+

[mkoeppe]

comment:5

Marking it as critical as it is needed for CI testing of blocker package upgrade ticket #29766

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5d13238

Merge tag '9.2.beta5' into t/30118/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

[sagetrac-git]

Changed commit from 25393b0 to 5d13238

[mkoeppe]

comment:8

Merged current beta, needs review

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:9

looks good as refactoring.
We'll see how the conditional deps work on follow-up tickets, I suppose

[mkoeppe]

comment:10

Thanks!