Remove ./configure --enable-SPKG options for pip packages (for which this is not implemented)

[mkoeppe]

As reported in https://groups.google.com/d/msg/sage-release/6hBUt5i9FLs/RM-2eCdcBgAJ:

It seems that if I do

./configure  --enable-beautifulsoup4

or

./configure  --enable-pyopenssl

I get

make[3]: ***  Aucune règle pour fabriquer la cible « /home/slabbe/GitBox/sage/local/var/lib
/sage/installed/beautifulsoup4-none », nécessaire pour « all-sage ». Arrêt.
make[3]: *** Attente des tâches non terminées....
...

make[3]: ***  Aucune règle pour fabriquer la cible « /home/slabbe/GitBox/sage/local/var/lib/sage/installed/pyopenssl-none », nécessaire pour « all-sage ». Arrêt.
...

and make stops with an error.

We remove these options as a quick fix for 9.1. Follow-up could be in #29097.

CC: @seblabbe @dimpase @jhpalmieri @orlitzky

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 2bb7d75

Reviewer: Sébastien Labbé, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/29626

[jhpalmieri]

comment:1

Related to #29113 and #29481, I'm guessing. See also #29418 comment:23.

[mkoeppe]

comment:2

It's trying to use a target that does exist for the case of pip packages. See macro PIP_PACKAGE_templ in build/make/Makefile.in

[mkoeppe]

comment:3

See also #29097, which needs to touch the same bits of the Makefile

[mkoeppe]

comment:4

For 9.1 a quick fix could be to disable the --enable-SPKG options for pip packages.

[mkoeppe]

Branch: u/mkoeppe/__configure___enable_spkg_does_not_work_for_optional_pip_packages

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 4d912a5

[mkoeppe]

New commits:

4d912a5

No --enable-spkg options for pip packages

[mkoeppe]

Description changed:

--- 
+++ 
@@ -21,3 +21,7 @@
 
 and make stops with an error.
 ```
+
+We remove these options as a quick fix for 9.1.  Follow-up could be in #29097.
+
+

[jhpalmieri]

comment:7

I suggest also removing this message in src/bin/sage:

    if [ -n "$ENABLE_ARGS" ]; then
        echo >&2 "Hint: These optional/experimental packages can also be configured"
        echo >&2 "to be installed by passing$ENABLE_ARGS to ./configure"
    fi

Or make it conditional on the type of package, but that seems a bit involved.

[jhpalmieri]

comment:8

What is standard ./configure behavior regarding bad flags? I see

$ ./configure --enable-pyflakes
configure: WARNING: unrecognized options: --enable-pyflakes

and then the warning message gets swept off the screen by all of the other messages. Should this be printed as part of a summary? Or do we assume that a user who knows enough to try something like this also knows enough to pay attention?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9d09cf4

src/bin/sage: Remove hints recommending ./configure --enable-SPKG

[sagetrac-git]

Changed commit from 4d912a5 to 9d09cf4

[mkoeppe]

comment:10

Replying to @jhpalmieri:

I suggest also removing this message in src/bin/sage:

    if [ -n "$ENABLE_ARGS" ]; then
        echo >&2 "Hint: These optional/experimental packages can also be configured"
        echo >&2 "to be installed by passing$ENABLE_ARGS to ./configure"
    fi

Done. Let's revisit this in the next release cycle.

Or make it conditional on the type of package, but that seems a bit involved.

I agree, too complicated

[mkoeppe]

comment:11

Replying to @jhpalmieri:

What is standard ./configure behavior regarding bad flags? I see

$ ./configure --enable-pyflakes
configure: WARNING: unrecognized options: --enable-pyflakes

and then the warning message gets swept off the screen by all of the other messages. Should this be printed as part of a summary? Or do we assume that a user who knows enough to try something like this also knows enough to pay attention?

That's normal and this part is not really configurable in autoconf.

One can disable these warning using --disable-option-checking, but I don't think there is an option to change these warnings to errors.