.homebrew-build-env: Set CPATH, LIBRARY_PATH instead of CPPFLAGS, LDFLAGS

[mkoeppe]

This is to fix a build error of pillow that arises when /usr/local/include/zip.h
shadows an include file "Zip.h". As reported in

• https://groups.google.com/d/msg/sage-release/aTSxEyE9Mrc/TWrEf3T5AgAJ

CC: @slel @jhpalmieri @dimpase

Component: build

Author: Matthias Koeppe

Branch: e74c6c2

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/29562

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,4 @@
-This is to fix a build error of `pillow` that arises when /usr/local/include/zip.h shadows an include file "Zip.h"
+This is to fix a build error of `pillow` that arises when /usr/local/include/zip.h shadows an include file "Zip.h".
+As reported in https://groups.google.com/d/msg/sage-release/aTSxEyE9Mrc/TWrEf3T5AgAJ
 
 

[mkoeppe]

Author: Matthias Koeppe

[slel]

Description changed:

--- 
+++ 
@@ -1,4 +1,5 @@
-This is to fix a build error of `pillow` that arises when /usr/local/include/zip.h shadows an include file "Zip.h".
-As reported in https://groups.google.com/d/msg/sage-release/aTSxEyE9Mrc/TWrEf3T5AgAJ
+This is to fix a build error of `pillow` that arises when `/usr/local/include/zip.h`
+shadows an include file "Zip.h". As reported in
 
+- https://groups.google.com/d/msg/sage-release/aTSxEyE9Mrc/TWrEf3T5AgAJ
 

[dimpase]

comment:4

should one be rather using brew sh shell?

[mkoeppe]

Branch: u/mkoeppe/_homebrew_build_env__set_cpath_instead_of_cppflags

[mkoeppe]

Commit: e74c6c2

[mkoeppe]

comment:6

Sorry, got distracted - here's the branch

---

New commits:

e74c6c2

.homebrew-build-env: Set CPATH, LIBRARY_PATH instead of CPPFLAGS, LDFLAGS

[mkoeppe]

comment:7

Replying to @dimpase:

should one be rather using brew sh shell?

I don't use that, but it's an interesting option.

[mkoeppe]

comment:8

Needs review

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:9

This works for me without libzip installed and also with it installed. If libzip is installed, then pillow fails to build without this branch. So I think it's ready to go.

[jhpalmieri]

comment:10

I tried running brew sh and not sourcing .homebrew-build-env, and Sage's configure file did not detect some packages: it suggested running

$ brew install cmake gsl isl gd ppl r

whereas it should ordinarily only suggest

$ brew install cmake ppl

[mkoeppe]

comment:11

Thanks!

Yes, let's postpone checking about brew sh until after the 9.1 release