tox.ini: Add raspbian-buster

[jaapspies]

On Raspberry Pi 4 4GB on Raspbian Buster build failed with fplll:

libtool: link: g++ -std=gnu++11 -std=c++11 -fPIC -I/home/pi/sagemath/sage-9.1.be
ta1/local/include/ -O3 -Wl,-rpath -Wl,/home/pi/sagemath/sage-9.1.beta1/local/lib
 -o .libs/fplll main.o  -L/home/pi/sagemath/sage-9.1.beta1/local/lib -L/lib ./.l
ibs/libfplll.so -lmpfr -lgmp -pthread -Wl,-rpath -Wl,/home/pi/sagemath/sage-9.1.
beta1/local/lib
/usr/bin/ld: ./.libs/libfplll.so: undefined reference to `__atomic_store_8'
/usr/bin/ld: ./.libs/libfplll.so: undefined reference to `__atomic_load_8'
collect2: error: ld returned 1 exit status

This is fixed by upgrading FPLLL in #30021.

In this ticket, we add Docker-based testing for the platform raspbian-buster-armhf so that it can be verified that FPLLL now builds on this platform by the following:

  tox -e docker-raspbian-buster-armhf-standard -- fplll

Depends on #30021

Upstream: Completely fixed; Fix reported upstream

CC: @malb @slel @fchapoton @kliem

Component: build

Keywords: raspberry

Author: Matthias Koeppe

Branch/Commit: 1b4c497

Reviewer: Jaap Spies

Issue created by migration from https://trac.sagemath.org/ticket/29091

[mkoeppe]

comment:1

Attachment: fplll-5.3.2.log

I have added raspbian-jessie and raspbian-stretch to #29143. There appears to be no Docker image for raspbian-buster.

[mkoeppe]

comment:2

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

[fchapoton]

Changed keywords from none to raspberry

[malb]

comment:4

This might be fixed upstream, can you try again? See fplll/fplll#418

[jaapspies]

comment:5

Replying to @malb:

This might be fixed upstream, can you try again? See fplll/fplll#418

Building sage-9.1 I get still the same ailure:

/bin/bash ../libtool  --tag=CXX   --mode=link g++ -std=gnu++11 -std=c++11  -fPIC -I/home/pi/sagemath/sage-9.1/local/include/ -L/home/pi/sagemath/sage-9.1/local/lib -O3  -Wl,-rpath-link,/home/pi/sagemath/sage-9.1/local/lib -L/home/pi/sagemath/sage-9.1/local/lib -Wl,-rpath,/home/pi/sagemath/sage-9.1/local/lib  -L/lib -o fplll main.o libfplll.la -lmpfr -lmpfr -lgmp -lgmp 
libtool: link: g++ -std=gnu++11 -std=c++11 -fPIC -I/home/pi/sagemath/sage-9.1/local/include/ -O3 -Wl,-rpath-link -Wl,/home/pi/sagemath/sage-9.1/local/lib -Wl,-rpath -Wl,/home/pi/sagemath/sage-9.1/local/lib -o .libs/fplll main.o  -L/home/pi/sagemath/sage-9.1/local/lib -L/lib ./.libs/libfplll.so -lmpfr -lgmp -pthread -Wl,-rpath -Wl,/home/pi/sagemath/sage-9.1/local/lib
/usr/bin/ld: ./.libs/libfplll.so: undefined reference to `__atomic_store_8'
/usr/bin/ld: ./.libs/libfplll.so: undefined reference to `__atomic_load_8'
collect2: error: ld returned 1 exit status
make[7]: *** [Makefile:1165: fplll] Error 1
make[7]: Leaving directory '/home/pi/sagemath/sage-9.1/local/var/tmp/sage/build/fplll-5.3.2/src/fplll'
make[6]: *** [Makefile:739: all] Error 2
make[6]: Leaving directory '/home/pi/sagemath/sage-9.1/local/var/tmp/sage/build/fplll-5.3.2/src/fplll'
make[5]: *** [Makefile:483: all-recursive] Error 1
make[5]: Leaving directory '/home/pi/sagemath/sage-9.1/local/var/tmp/sage/build/fplll-5.3.2/src'
make[4]: *** [Makefile:370: all] Error 2
make[4]: Leaving directory '/home/pi/sagemath/sage-9.1/local/var/tmp/sage/build/fplll-5.3.2/src'
********************************************************************************
Error building fplll-5.3.2
********************************************************************************

real	51m45.333s
user	67m10.859s
sys	1m31.680s
************************************************************************
Error installing package fplll-5.3.2
************************************************************************
Please email sage-devel (http://groups.google.com/group/sage-devel)
explaining the problem and including the log file
  /home/pi/sagemath/sage-9.1/logs/pkgs/fplll-5.3.2.log
Describe your computer, operating system, etc.
If you want to try to fix the problem yourself, *don't* just cd to
/home/pi/sagemath/sage-9.1/local/var/tmp/sage/build/fplll-5.3.2 and type 'make' or whatever is appropriate.
Instead, the following commands setup all environment variables
correctly and load a subshell for you to debug the error:
  (cd '/home/pi/sagemath/sage-9.1/local/var/tmp/sage/build/fplll-5.3.2' && '/home/pi/sagemath/sage-9.1/sage' --buildsh)
When you are done debugging, you can type "exit" to leave the subshell.
************************************************************************

[malb]

comment:6

Sorry that fix isn't in Sage (or an upstream release yet). I meant trying upstream master. I should cut a new release, though.

[slel]

Upstream: Reported upstream. Developers acknowledge bug.

[slel]

Description changed:

--- 
+++ 
@@ -1,7 +1,6 @@
+On Raspberry Pi 4 4GB on Raspbian Buster build failed with fplll:
 
 ```
-On Raspberry Pi 4 4GB on Raspbian Buster build failed with fplll:
-
 libtool: link: g++ -std=gnu++11 -std=c++11 -fPIC -I/home/pi/sagemath/sage-9.1.be
 ta1/local/include/ -O3 -Wl,-rpath -Wl,/home/pi/sagemath/sage-9.1.beta1/local/lib
  -o .libs/fplll main.o  -L/home/pi/sagemath/sage-9.1.beta1/local/lib -L/lib ./.l
@@ -10,5 +9,4 @@
 /usr/bin/ld: ./.libs/libfplll.so: undefined reference to `__atomic_store_8'
 /usr/bin/ld: ./.libs/libfplll.so: undefined reference to `__atomic_load_8'
 collect2: error: ld returned 1 exit status
-
 ```

[slel]

comment:7

I opened this issue in the fplll issue tracker

• Fix ARM-specific problem with new multicore code in fplll 5.3.x

  Fix ARM-specific problem with new multicore code in fplll 5.3.x fplll/fplll#432

but apparently this issue might have been relevant

• add -latomic when needed

  add -latomic when needed fplll/fplll#418

and it was fixed in Apr 2020 by this pull request

• check for -latomic

  check for -latomic fplll/fplll#419

The current latest release, fplll 5.3.2, is from Jan 2020.
Thus the fix should be tried by using the master branch.
I hope it fixes things and the next release works on ARM.
Sorry for the extra noise.

[mkoeppe]

Branch: u/mkoeppe/raspian-buster

[mkoeppe]

comment:9

I have just added a test environment for raspbian-buster.
You can try

tox -e docker-raspbian-buster-standard -- fplll

---

New commits:

e5e2244	tox.ini, build/bin/write-dockerfile.sh: Add raspbian-buster
714bdce	.github/workflows/tox*.yml: Add raspbian-stretch, raspbian-buster