Deprecate to_sage() and structure_sheaf() in Macaulay2 interface

[mwageringel]

For consistency with other interfaces, the method to_sage() for converting Macaulay2Elements to Sage should be deprecated and replaced by sage(). More precisely, the method _sage_() inherited from a super class should be implemented.

Similarly, the Sage method structure_sheaf() should be deprecated in favor of the Macaulay2 function sheaf() which provides the same functionality. Since structure_sheaf() is implemented for any Macaulay2Element, even for elements that do not support it, it unnecessarily pollutes the tab completion menu. In contrast, sheaf() only appears in the completion menu if an element supports it.

Component: interfaces

Keywords: macaulay2, deprecation

Author: Markus Wageringel

Branch/Commit: e0ead46

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27848

[mwageringel]

comment:1

I have implemented the deprecations and also fixed all the failing doctests involving Macaulay2, which I tested using Macaulay2 1.11 and 1.13 on OS X.

Since the Macaulay2 description of matrices changed in 1.13, I also added code to ensure these matrices have the correct string representation within Sage (see the commit message for details).

To run the tests on all files that have optional Macaulay2 doctests, you can use:

sage -t --long --optional=sage,macaulay2 $(grep -i "optional.*macaulay2" -r src/sage -l | paste -sd " " -)

---

New commits:

8bd9f5d	Fixed further Macaulay2-related doctests
406beb2	fix ascii art for matrices in Macaulay2 1.13+
50bc660	deprecate Macaulay2Element.to_sage
9f0b05c	deprecate Macaulay2Element.structure_sheaf

[mwageringel]

Author: Markus Wageringel

[mwageringel]

Commit: 9f0b05c

[mwageringel]

Branch: u/gh-mwageringel/macaulay2_deprecations

[fchapoton]

comment:2

With python3-sage, and M2 (version 1.14) installed and working, and this ticket's branch, I get

sage -t --long src/sage/matrix/matrix1.pyx  # 2 doctests failed
sage -t --long src/sage/interfaces/macaulay2.py  # 2 doctests failed

Some of these failures may be there without the branch here.

[fchapoton]

comment:3

The matrix failure should be an easy fix: please replace

entries = map(list, self)

by

entries = [list(c) for c in self]

in the macaulay method in the file matrix1.pyx.

[fchapoton]

comment:4

The other failure is a "bytes versus string" problem.

EDIT:

This shoud be fixed by replacing

return s

by
return bytes_to_str(s)
in the
_sage_src_ method of the M2 interface.

[fchapoton]

Changed branch from u/gh-mwageringel/macaulay2_deprecations to public/ticket/27848

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:5

I have made my suggested changes. If you agree with them, you can set this ticket to positive review.

---

New commits:

a4036cd	Fixed further Macaulay2-related doctests
c0321d3	fix ascii art for matrices in Macaulay2 1.13+
7fe0483	deprecate Macaulay2Element.to_sage
68b5715	deprecate Macaulay2Element.structure_sheaf
e0ead46	py3 fixes