optional package deformation fails to build

[videlec]

On archlinux

/usr/bin/ld: -r and -pie may not be used together

See the more complete log attachment: deformation-d05941b.log.

Upstream report: jpflori/pydeformation#5

A patch is provided in #24575.

CC: @jpflori

Component: packages: optional

Issue created by migration from https://trac.sagemath.org/ticket/24902

[videlec]

Description changed:

--- 
+++ 
@@ -4,4 +4,4 @@
 /usr/bin/ld: -r and -pie may not be used together
 ```
 
-See the more complete log at XXX
+See the more complete log [attachment: deformation-d05941b.log](https://github.com/sagemath/sage-prod/files/10659123/deformation-d05941b.log).

[videlec]

comment:1

Attachment: deformation-d05941b.log

[kiwifb]

comment:2

Flint had that issue some time ago. This is caused by the hardening of the toolchain. Look at what has been done for flint here
https://github.com/sagemath/sage-prod/blob/master/build/pkgs/flint/patches/flint-pie-hardening-conflict.patch. Basically you give -r directly to the compiler but don't pass it directly to the linker as you would with -Wl,-r.

[kiwifb]

comment:4

The culprit is this line

Makefile.subdirs:       $(QUIET_CC) $(CC) $(ABI_FLAG) -Wl,-r $^ -o $@ -nostdlib

Change -Wl,-r to plain -r should get you in business. Can someone also please update SPKG.txt with upstream location? Where did you get that tarball from? Has it been processed before being put on the mirror?

[videlec]

comment:5

A patch is provided in #24575, should I move it here?

[videlec]

comment:6

Replying to @videlec:

A patch is provided in #24575, should I move it here?

[kiwifb]

comment:7

No need we can just mark this ticket as a "duplicate" of #24575.

[videlec]

Description changed:

--- 
+++ 
@@ -5,3 +5,5 @@
 ```
 
 See the more complete log [attachment: deformation-d05941b.log](https://github.com/sagemath/sage-prod/files/10659123/deformation-d05941b.log).
+
+A patch is provided in #24575.

[videlec]

Description changed:

--- 
+++ 
@@ -6,4 +6,6 @@
 
 See the more complete log [attachment: deformation-d05941b.log](https://github.com/sagemath/sage-prod/files/10659123/deformation-d05941b.log).
 
+Upstream report: https://github.com/jpflori/pydeformation/issues/5
+
 A patch is provided in #24575.