Simplify qhull spkg patch

[mkoeppe]

This is for #21534.

The ticket also changes "make -j1" to "$MAKE".
The "-j1" should be unnecessary. The Makefile.patch purports to fix the dependency problems of the original Makefile; and a parallel build works for me with it.

CC: @videlec @jdemeyer @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 808f960

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/21572

[mkoeppe]

Branch: u/mkoeppe/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local

[mkoeppe]

Commit: ac49e35

[mkoeppe]

New commits:

19360c0	Don't patch DESTDIR in Makefile, just pass it as an argument
ac49e35	Use make -j8, remove -j1 for building

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,5 +1,5 @@
 This is for #21534.
 
-The ticket also changes "make -j1" to "$(MAKE)". 
-The "-j1" should be unnecessary. The `Makefile.patch` purports to fix the dependency problems of the original Makefile.
+The ticket also changes "make -j1" to "$MAKE". 
+The "-j1" should be unnecessary. The `Makefile.patch` purports to fix the dependency problems of the original Makefile; and a parallel build works for me with it.
 

[mkoeppe]

Author: Matthias Koeppe

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

Changed branch from u/mkoeppe/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local to u/jdemeyer/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local

[jdemeyer]

comment:6

Fixed commit message of last commit

---

New commits:

30bf5d5

Use $MAKE, remove -j1 for building

[jdemeyer]

Changed commit from ac49e35 to 30bf5d5

[jdemeyer]

comment:7

I do get failures with a parallel build:

============================================
== make qtest ==============================
============================================
== Otherwise if user_eg fails to link, switch to -lqhullstatic_r
bin/qconvex
== Sun Sep 25 09:26:10 CEST 2016

============================================
QH6075 == Test non-reentrant qset.c with mem.c ====
qhull input error: short input file.  Did not find dimension and number of points

While executing:  | qconvex
Options selected for Qhull 2015.2 2016/01/18:
  run-id 511880916
Makefile:323: recipe for target 'qconvex-prompt' failed
make: *** [qconvex-prompt] Error 1
make: *** Waiting for unfinished jobs....

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

808f960

Use $MAKE instead of make

[sagetrac-git]

Changed commit from 30bf5d5 to 808f960

[jdemeyer]

comment:9

Put back the -j1 option. Please check and then set this to positive_review if you agree.

[mkoeppe]

comment:10

Thanks for testing this thoroughly.