Cleaning of subword complex code

[stumpc5]

CC: @tscrim @fchapoton

Component: combinatorics

Keywords: subword complex

Author: Christian Stump

Branch/Commit: e8ad2a9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20111

[stumpc5]

Branch: u/stumpc5/cleaning_of_subword_complex_code

[stumpc5]

comment:2

Using the category framework for subword complexes.

TODO: make subword complex elements instances of its category element class

sage: W = CoxeterGroup(['A',2])
sage: w = W.from_reduced_word([1,2,1])
sage: S = SubwordComplex([1,2,1,2,1],w)
sage: F = S.an_element()
sage: isinstance(F,F.parent().category().element_class)
False
sage: type(F)
<class 'sage.combinat.subword_complex.SubwordComplexFacet'>
sage: F.parent().category().element_class
<class 'sage.categories.simplicial_complexes.SimplicialComplexes.Finite.element_class'>

---

New commits:

924a4d9

cleaning of the subword complex code

[stumpc5]

Author: Christian Stump

[stumpc5]

Commit: 924a4d9

[stumpc5]

Changed keywords from none to subword complex

[stumpc5]

comment:3

The diff is a pain -- I had to interchange the appearance of the classes SubwordComplex and SubwordComplexFacet in the file in order to write Element = SubwordComplexFacet into the SubwordComplex class.

So what did I change:

• the the init of subword complex
• added the __classcall__ method to make parents unique
• tiny changes to make the input a tuple instead of a list (this also forced changes in multiple other places such as Q.reverse or in the function definition of the cython file.

Once the above issue is solved, this is ready for review.

[tscrim]

comment:4

Instead of reordering, you could have just added (at the module level) SubwordComplex.Element = SubwordComplexFacet (although in some ways I think the reordered way is better, but we can get to that after we decide the color of the bikeshed). As for the issue above, all you should have to do replacements like this:

-return SubwordComplexFacet(self, F, facet_test=facet_test)
+return self.element_class(self, F, facet_test=facet_test)

[sagetrac-git]

Changed commit from 924a4d9 to 8b74225

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8b74225

fixed the parent type problem for subwordcomplexfacet

[stumpc5]

comment:6

Thanks, that worked. It's ready for review I guess!