TransitiveIdeal -> RecursivelyEnumeratedSet in the sage library

[seblabbe]

TransitiveIdeal and TransitiveIealGraded are used in the code of sage/combinat, sage/categories and sage/groups at least. These should be replaced by RecursivelyEnumeratedSet for speed improvements and also to avoid issues explained in #6637.

This is a follow up of #6637 where TransitiveIdeal and TransitiveIealGraded have been deprecated.

More precisely, occurences of

TransitiveIdeal(succ, seeds)
TransitiveIdealGraded(succ, seeds, max_depth)

are replaced (respectively) by:

RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='naive')
RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='breadth', max_depth=max_depth)

Indeed, deprecated TransitiveIdealGraded class was not using the hypothesis of being graded in its code. This is why the structure is set to None for now. Of course, if people have really a graded structure, then the structure argument should be set to 'graded'... For now, I am keeping the behavior like it was before and I am assuming the structure is not graded.

CC: @anneschilling @tscrim

Component: combinatorics

Keywords: sd66

Author: Sébastien Labbé

Branch/Commit: 0beb042

Reviewer: Vincent Delecroix, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/16352

[seblabbe]

Description changed:

--- 
+++ 
@@ -1,3 +1,23 @@
 `TransitiveIdeal` and `TransitiveIealGraded` are used in the code of `sage/combinat`, `sage/categories` and `sage/groups` at least. These should be replaced by `RecursivelyEnumeratedSet` for speed improvements and also to avoid issues explained in #6637.
 
 This is a follow up of #6637 where `TransitiveIdeal` and `TransitiveIealGraded` have been deprecated.
+
+More precisely, occurences of
+
+   `TransitiveIdeal(succ, seeds)`
+
+are replaced by:
+
+   `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='naive')`
+
+and occurences of
+
+   `TransitiveIdealGraded(succ, seeds, max_depth)`
+
+are replaced by:
+
+   `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='breadth', max_depth=max_depth)`
+
+Indeed, old transitive ideal *graded* was not using the hypothesis of being graded in the code. This is why the structure is set to `None` now. Of course, if people have *really* a graded structure, then the structure should be set to `'graded'`... For now, I am keeping the behavior like it was before to avoid problems.
+
+

[seblabbe]

Description changed:

--- 
+++ 
@@ -5,19 +5,11 @@
 More precisely, occurences of
 
    `TransitiveIdeal(succ, seeds)`
+   `TransitiveIdealGraded(succ, seeds, max_depth)`
 
-are replaced by:
+are replaced (respectively) by:
 
    `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='naive')`
-
-and occurences of
-
-   `TransitiveIdealGraded(succ, seeds, max_depth)`
-
-are replaced by:
-
    `RecursivelyEnumeratedSet(seeds, succ, structure=None, enumeration='breadth', max_depth=max_depth)`
 
-Indeed, old transitive ideal *graded* was not using the hypothesis of being graded in the code. This is why the structure is set to `None` now. Of course, if people have *really* a graded structure, then the structure should be set to `'graded'`... For now, I am keeping the behavior like it was before to avoid problems.
-
-
+Indeed, deprecated `TransitiveIdealGraded` class was not using the hypothesis of being graded in its code. This is why the structure is set to `None` for now. Of course, if people have *really* a graded structure, then the structure argument should be set to `'graded'`... For now, I am keeping the behavior like it was before to avoid problems and also because it seems that `TransitiveIdealGraded` was used in places where the structure was not graded...

[seblabbe]

Commit: 7956b77

[seblabbe]

Branch: u/slabbe/16352

[seblabbe]

New commits:

7956b77

replacing TransitiveIdeal by RecursivelyEnumeratedSet in sage library

[seblabbe]

Changed keywords from none to sd66

[sagetrac-git]

Changed commit from 7956b77 to 67e950d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

67e950d

replacing TransitiveIdeal by RecursivelyEnumeratedSet in sage library