sage.misc.sage_ostools.have_program: use os.access()

[jdemeyer]

The following is an error I cannot reproduce:

sage -t --long devel/sage/sage/misc/dist.py
**********************************************************************
File "devel/sage/sage/misc/dist.py", line 73, in sage.misc.dist.install_scripts
Failed example:
    install_scripts(str(SAGE_TMP), ignore_existing=True)
Expected:
    Checking that Sage has the command 'gap' installed
    ...
Got:
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    Checking that Sage has the command 'gap' installed
    The command 'gap' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'gp' installed
    The command 'gp' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'hg' installed
    The command 'hg' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'ipython' installed
    The command 'ipython' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'maxima' installed
    The command 'maxima' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'mwrank' installed
    The command 'mwrank' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'R' installed
    The command 'R' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'singular' installed
    The command 'singular' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'sqlite3' installed
    The command 'sqlite3' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'M2' installed
    The command 'M2' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'kash' installed
    The command 'kash' is not available as part of Sage; not creating script.
    <BLANKLINE>
    No scripts created.
**********************************************************************

Component: misc

Author: Jeroen Demeyer

Reviewer: David Roe

Merged: sage-5.9.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14253

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
-On Solaris, the default `/bin/sh` shell doesn't understand the `command` keyword, but `bash` does.
+1) On Solaris, the default `/bin/sh` shell doesn't understand the `command` keyword.
+2) Using `os.access()` should be more portable and less prone to errors anyway than `command -v %s`.

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1,2 +1,59 @@
-1) On Solaris, the default `/bin/sh` shell doesn't understand the `command` keyword.
-2) Using `os.access()` should be more portable and less prone to errors anyway than `command -v %s`.
+The following is an error I cannot reproduce:
+
+```
+sage -t --long devel/sage/sage/misc/dist.py
+**********************************************************************
+File "devel/sage/sage/misc/dist.py", line 73, in sage.misc.dist.install_scripts
+Failed example:
+    install_scripts(str(SAGE_TMP), ignore_existing=True)
+Expected:
+    Checking that Sage has the command 'gap' installed
+    ...
+Got:
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    /bin/sh: command: not found
+    Checking that Sage has the command 'gap' installed
+    The command 'gap' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'gp' installed
+    The command 'gp' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'hg' installed
+    The command 'hg' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'ipython' installed
+    The command 'ipython' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'maxima' installed
+    The command 'maxima' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'mwrank' installed
+    The command 'mwrank' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'R' installed
+    The command 'R' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'singular' installed
+    The command 'singular' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'sqlite3' installed
+    The command 'sqlite3' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'M2' installed
+    The command 'M2' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    Checking that Sage has the command 'kash' installed
+    The command 'kash' is not available as part of Sage; not creating script.
+    <BLANKLINE>
+    No scripts created.
+**********************************************************************
+```

[jdemeyer]

comment:3

Attachment: 14253_have_program.patch.gz

[roed314]

comment:4

Looks good to me.

[roed314]

Reviewer: David Roe

[jdemeyer]

Merged: sage-5.9.beta0