Remove CombinatorialClass from Compositions

[tscrim]

Part of #12913.

Depends on #14065

CC: @sagetrac-sage-combinat @nthiery

Component: combinatorics

Keywords: deprecation

Author: Travis Scrimshaw

Reviewer: Vincent Delecroix

Merged: sage-5.8.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14063

[tscrim]

Dependencies: #14065

[tscrim]

Author: Travis Scrimshaw

[videlec]

comment:2

Hi,

• composition_from_subset must be renamed to from_subset
• You may remove the few trailing whitespaces that remain.

The rest looks good.

Vincent

[videlec]

comment:3

Comments on the doc in composition.py

• line 786: list(Compositions(4)) may be replaced with Compositions(4).list() (idem lines 877, 882, 927)
• line 844: there is a strange sharp at the end of the line
• line 859: a space is missing

[tscrim]

comment:4

Made fixes based on your comments.

Thanks,

Travis

[videlec]

comment:5

Great job !

Vincent

[jdemeyer]

Reviewer: Vincent Delecroix