Upgrade ECL to 12.12.1 and let it build on (recent) Cygwins

[jpflori]

On my 1.7.16 installation of Cygwin, the ecl spkg does not build because it defines unconditionaly _WINSOCKAPI_ in h/ecl-cmp.h which then prevents the definition of fd_set in /usr/include/sys/types.h.
I guess this is harmless on Linux, intended on Windows, but on Cygwin this breaks the build of ECL.

The proposed spkg patches h/ecl-cmp.h so that _WINSOCKAPI_ is not defined on CYGWIN.
This has been merged upstream and is in 12.12.1:
https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/

Moreover comes patches from upstream to get correct signal handling and is in 12.12.1:

• http://sourceforge.net/p/ecls/ecl/ci/c4a538dd278407f91f6105ebbeadf1b371c1124f/
• http://sourceforge.net/p/ecls/ecl/ci/15033d5a8ad7297e5f76e2e70446b0eea2f2d2a7/
• http://sourceforge.net/p/ecls/ecl/ci/ec1fe8781a5f137284cc6c0d0cfa6b0cc9b9b291/

We build ECL single threaded to get hopefully more correct signal handling in library mode and avoid problems with the pexpect interface.

And a later patch to avoid infinite loops while compiling lisp to C:
http://sourceforge.net/p/ecls/ecl/ci/13459a98f0c0c58ccc4e9241c3bf0625e39f2383/

Older patches which are now upstream have been removed.

Be sure to use Sage 5.6.beta2 or higher, so that the Maxima spkg is ready for this.

Try spkg at
http://boxen.math.washington.edu/home/jpflori/ecl-12.12.1.p0.spkg

Apply:

• attachment: trac_13324.patch (Trivial doctest patch fixing a changed error message.)
• attachment: trac_13324.2.patch (Cleanup lisp.py and remove a problematic \n in _synchronize)

Depends on #13860

Upstream: Fixed upstream, but not in a stable release.

CC: @kiwifb

Component: porting: Cygwin

Keywords: cygwin ecl spkg

Author: Jean-Pierre Flori

Reviewer: François Bissey, Karl-Dieter Crisman, Dmitrii Pasechnik

Merged: sage-5.7.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13324

[nexttime]

Changed keywords from cygwin ecl to cygwin ecl spkg

[jpflori]

Changed upstream from Not yet reported upstream; Will do shortly. to Workaround found; Bug reported upstream.

[jpflori]

comment:4

Wrong ticket...

[dimpase]

comment:5

Good, this also works on my Cygwin (and this change of spkg is needed, too).

[dimpase]

comment:6

however, after the whole Sage build on my Cygwin is almost done, I get

...
building 'sage.ext.interpreters.wrapper_py' extension
building 'sage.ext.interpreters.wrapper_el' extension
Executing 241 commands (using 1 thread)
gcc -I/usr/include/ncurses -fno-strict-aliasing -fwrapv -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/home/Dima/sage-5.2.rc1/local/include/ecl/ -I/home/Dima/sage-5.2.rc1/local/include -I/home/Dima/sage-5.2.rc1/local/include/csage -I/home/Dima/sage-5.2.rc1/devel/sage/sage/ext -I/home/Dima/sage-5.2.rc1/local/include/python2.7 -c sage/libs/ecl.c -o build/temp.cygwin-1.7.16-i686-2.7/sage/libs/ecl.o -w
gcc -shared -Wl,--enable-auto-image-base -L/home/Dima/sage-5.2.rc1/local/lib build/temp.cygwin-1.7.16-i686-2.7/sage/libs/ecl.o -L/home/Dima/sage-5.2.rc1/local/lib -L/home/Dima/sage-5.2.rc1/local/lib/python2.7/config -lcsage -lecl -lstdc++ -lntl -lpython2.7 -o build/lib.cygwin-1.7.16-i686-2.7/sage/libs/ecl.dll
build/temp.cygwin-1.7.16-i686-2.7/sage/libs/ecl.o: In function `ecl_bignum_from_mpz':
/home/Dima/sage-5.2.rc1/devel/sage/sage/libs/eclsig.c:52: undefined reference to `__imp____gmpz_set'
/home/Dima/sage-5.2.rc1/devel/sage/sage/libs/eclsig.c:52: undefined reference to `__imp____gmpz_set'
collect2: ld returned 1 exit status
gcc -I/usr/include/ncurses -fno-strict-aliasing -fwrapv -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/home/Dima/sage-5.2.rc1/local/include/FLINT/ -I/home/Dima/sage-5.2.rc1/local/include -I/home/Dima/sage-5.2.rc1/local/include/csage -I/home/Dima/sage-5.2.rc1/devel/sage/sage/ext -I/home/Dima/sage-5.2.rc1/local/include/python2.7 -c sage/libs/flint/flint.c -o build/temp.cygwin-1.7.16-i686-2.7/sage/libs/flint/flint.o -std=c99 -D_XPG6 -w
error: command 'gcc' failed with exit status 1
Error installing modified sage library code.

A missing library somewhere?

[jpflori]

comment:7

That was expected.
In fact I guess the build is not nearing the end at all.

You can rerun "./sage -b" and you'll see that a lot of cpp files produced from pyx files still have to be compiled.
The first that should refail then is ecl.cpp.
See #13334 for that one.

For the following ones I've not opened tockets yet, but there should be instructions enough on the CygwinPort page (although you'll have to implement the ideas evoked there yourself, no code provided).

[jpflori]

Changed upstream from Workaround found; Bug reported upstream. to Fixed upstream, but not in a stable release.

[jpflori]

comment:9

The fix has been integrated upstream
https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/

[jpflori]

Description changed:

--- 
+++ 
@@ -2,6 +2,8 @@
 I guess this is harmless on linux, intended on Windows, but on Cygwin this breaks the build of ECL.
 
 The proposed spkg patches h/ecl-cmp.h so that `_WINSOCKAPI_` is not defined on CYGWIN.
+This has been merged upstream:
+https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/
 
 Try spkg at
 http://perso.telecom-paristech.fr/~flori/sage/ecl-11.1.2.cvs20111120.p2.spkg