convert.pyx: fix build with Python 3.11 #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Python 3.9, Python provides Py_SET_SIZE to set size of Object. From Python 3.11, Py_SIZE is no longer a macro, it's converted to a function, thus its return value is now prvalue. Cython provides a function to set size from 0.29.20 [1]. Let's use that instead. [1]: cython/cython#3639
Collaborator
|
Thanks. However, this is duplication from #103. |
Collaborator
|
But nevertheless a good reminder that this should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Python 3.9, Python provides Py_SET_SIZE to set size of Object. From Python 3.11, Py_SIZE is no longer a macro, it's converted to a function, thus its return value is now prvalue.
Cython provides a function to set size from 0.29.20 1.
Let's use that instead.