Skip to content

Conversation

@rustprooflabs
Copy link
Owner

Details

I was able to upgrade the extensions packaged in this Docker image to support Postgres 17 (see PgDD 0.6.0 and Convert 0.0.4).

After I got those in place, it seems trivial to switch this project over to Postgres 17.

Output from make

Test output reports zero issues.

.
----------------------------------------------------------------------
Ran 49 tests in 2.060s

OK
docker exec -it \
	-e POSTGRES_PASSWORD=mysecretpassword \
	-e POSTGRES_USER=postgres \
	-u 1000:1000 \
	pgosm /bin/bash -c "cd docker && coverage report -m ./*.py"
Name                            Stmts   Miss  Cover   Missing
-------------------------------------------------------------
./db.py                           306    199    35%   85-87, 93-95, 121-122, 146-173, 185-195, 201-209, 226-252, 277-302, 328-330, 348-356, 372-386, 402-417, 430-431, 450-461, 478-481, 496-513, 525-561, 571-576, 590-610, 622-645, 657-661, 675-693, 724
./geofabrik.py                    109     76    30%   47-73, 85-107, 131-143, 146-148, 173, 188-202, 226-234, 251-262, 274-281
./helpers.py                      168     20    88%   67, 74-75, 144-145, 212-213, 219-226, 335-342, 352
./osm2pgsql_recommendation.py      23      8    65%   33-48
./pgosm_flex.py                   257    153    40%   82-195, 219-253, 269-291, 330, 412, 428-440, 457-471, 531-550, 563-570, 580-595, 606-623, 627-628
./qgis_styles.py                   48     38    21%   22-28, 39-49, 62-71, 82-100, 110-125
-------------------------------------------------------------
TOTAL                             911    494    46%
# Data import tests
docker cp tests \
	pgosm:/app/tests
Successfully copied 28.5MB to pgosm:/app/tests
docker exec -it pgosm \
	chown 1000:1000 /app/tests/
# Errors when running under docker are saved in
#  /app/tests/tmp/<test_with_error>.diff
docker exec -it \
	-e POSTGRES_PASSWORD=mysecretpassword \
	-e POSTGRES_USER=postgres \
	-u 1000:1000 \
	pgosm /bin/bash -c "cd tests && ./run-output-tests.sh"
Running PgOSM-Flex test queries
Data output tests completed successfully.

real	1m28.951s
user	0m0.377s
sys	0m0.305s

@rustprooflabs rustprooflabs added this to the 1.1.1 milestone May 25, 2025
@rustprooflabs rustprooflabs self-assigned this May 25, 2025
@rustprooflabs rustprooflabs added enhancement New feature or request Docker Docker image and/or related script(s) labels May 25, 2025
@rustprooflabs rustprooflabs changed the base branch from main to dev May 25, 2025 14:32
@rustprooflabs
Copy link
Owner Author

Merging into dev, pushed image for final testing before merging to main.

docker pull rustprooflabs/pgosm-flex:pg17

If anyone tests this (successfully or not!), let me know how it goes! 😄

@rustprooflabs rustprooflabs merged commit 9b55f59 into dev May 25, 2025
3 checks passed
@rustprooflabs rustprooflabs deleted the postgres-17 branch May 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docker Docker image and/or related script(s) enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant