Skip to content

add InvalidStarSegmentSelectors #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2021
Merged

add InvalidStarSegmentSelectors #317

merged 2 commits into from
Nov 6, 2021

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Oct 25, 2021

This pr makes Star::write return Result<(), InvalidStarSegmentSelectors> instead of Result<(), &'static str>.

This is a breaking change.

@phil-opp phil-opp added the waiting-for-review Waiting for a review from the maintainers. label Nov 6, 2021
phil-opp
phil-opp approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks a lot!

@phil-opp phil-opp merged commit a96abb2 into rust-osdev:next Nov 6, 2021
@Freax13 Freax13 mentioned this pull request Jan 14, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
waiting-for-review Waiting for a review from the maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @phil-opp