Skip to content

Enable instructions module when generating docs #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable instructions module when generating docs #308

wants to merge 1 commit into from

Conversation

@npmccallum
Copy link
Member

@npmccallum npmccallum commented Sep 16, 2021

Fixes: #307

Signed-off-by: Nathaniel McCallum [email protected]

@phil-opp
Copy link
Member

phil-opp commented Sep 17, 2021 •
edited
Loading

I don't think that this is a good idea to always show the instructions in the docs, even if they're not available. I'm currently working on a different solution to #307 though.

Edit: I opened a PR with an alternative solution in #309.

@phil-opp phil-opp mentioned this pull request Sep 17, 2021
Closed
@npmccallum
Copy link
Member Author

npmccallum commented Sep 17, 2021

@phil-opp No worries. I was just trying to save you some time. :)

@npmccallum npmccallum closed this Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cargo doc is broken when default-featues = false

2 participants

@npmccallum @phil-opp