Skip to content

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Mar 12, 2023

Follow-up to #350, which failed on cargo publish.

  • Fix: Don't use bootloader_test_runner dev-dependency in features list

@phil-opp phil-opp enabled auto-merge March 12, 2023 16:02
@phil-opp phil-opp merged commit fa87d01 into main Mar 12, 2023
@phil-opp phil-opp deleted the release branch March 12, 2023 16:18
@phil-opp phil-opp mentioned this pull request Dec 27, 2023
phil-opp added a commit that referenced this pull request Dec 27, 2023
The test runner was accidentally disabled in #351, in an attempt to fix the publish errors introduced by #304 (caused by a bug in cargo: rust-lang/cargo#12225). As a result, the test runner became a no-op as neither the bios nor the uefi features were enabled.

This commit fixes the issue by enabling both features by default. Once the cargo bug is fixed, we might want to switch back to the feature configuration added of #304.

Fixes #405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant