Add cargo keywords and categories. #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failure is surely unrelated to my change - the failures are |
cuviper
reviewed
Jul 10, 2017
Cargo.toml
Outdated
| @@ -3,7 +3,8 @@ authors = ["The Rust Project Developers"] | |||
| description = "A collection of numeric types and traits for Rust, including bigint,\ncomplex, rational, range iterators, generic integers, and more!\n" | |||
| documentation = "http://rust-num.github.io/num" | |||
| homepage = "https://github.com/rust-num/num" | |||
| keywords = ["mathematics", "numerics"] | |||
| keywords = ["mathematics", "numerics", "bignum"] | |||
| categories = [ "algorithms", "data-structures", "science", "cryptography" ] | |||
There was a problem hiding this comment.
It seems a little bit of a stretch to say "science", but there aren't any math categories, so I guess that will do.
I'm less comfortable with "cryptography" though. Yes, bigints are usually needed to implement crypto, but we don't implement any crypto algorithms here.
There was a problem hiding this comment.
Thanks. Rebased, and I've added some suggestions to the subcrates. The category slugs are a bit lacking, IMHO, and I also don't understand the purpose of all the subcrates, so again any suggestions are welcome!
Resolves rust-num#306. Suggestions welcome for better keywords/categories, though there is a limit of 5 of each.
|
It's been rebased. |
|
Thanks! bors r+ |
Build succeeded |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306. Suggestions welcome for better keywords/categories, though there is a limit of 5 of each.