bigint: Remove parse_bytes method
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gifnksm
changed the title
gifnksm
changed the title
parse_bytes method
|
Could you rebase this after #21 now? It looks like the method didn't have to be removed entirely. |
This follows the changes of "Separate string->integer implementation in strconv" (rust-lang/rust@138b76b). This allows `parse_bytes` to be removed without breaking `libnum` code.
|
@alexcrichton rebased. |
|
Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Nov 4, 2014
bigint: Remove `parse_bytes` method
remexre
pushed a commit
to remexre/num
that referenced
this pull request
Jun 1, 2017
This resolves rust-num#22, resolves rust-num#29, and resolves rust-num#30. * The reported error code is now `MissingField`, not `ExpectedSomeValue`. * A missing `()` field now causes a `MissingField` error. * A missing `Vec<_>` field now causes a `MissingField` error. Tests have been updated to check these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit follows the changes of "Separate string->integer implementation in strconv" (rust-lang/rust@138b76b)
This PR also contains some minor improvements (second and third commits)