Skip to content

Conversation

@daniel-noland
Copy link
Contributor

@daniel-noland daniel-noland commented Apr 2, 2024

First time contributor.

I tried to follow existing patterns.
Let me know if you want something done differently.

closes #40

@daniel-noland daniel-noland marked this pull request as ready for review April 2, 2024 22:25
@daniel-noland daniel-noland changed the title DRAFT: Implement add vrf link (issue #40) Implement add vrf link (issue #40) Apr 3, 2024
* Implemented add vrf link
* Adjusted CI to modprobe vrf for tests
@daniel-noland daniel-noland force-pushed the issue-40/vrf-links branch 3 times, most recently from a8937fb to 06c3299 Compare April 5, 2024 19:20
@daniel-noland
Copy link
Contributor Author

Looks like I messed up the formatting on the prior run (sorry about that).
I ran this through CI on my fork and it passes now.

Not sure of procedure / etiquette for requesting workflow run / re-review.

Copy link
Contributor

@wllenyj wllenyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathay4t cathay4t merged commit 6863102 into rust-netlink:main Apr 8, 2024
@cathay4t
Copy link
Member

cathay4t commented Apr 8, 2024

Merged. Thanks!

frederic-loui added a commit to frederic-loui/rtnetlink that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API to add vrf links is missing

3 participants