Skip to content

Code size improvement in .zip_mut_with() #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 29, 2017
Merged

Code size improvement in .zip_mut_with() #290

merged 6 commits into from
Mar 29, 2017

Conversation

@bluss
Copy link
Member

@bluss bluss commented Mar 29, 2017

  • Use a new form of the InnerIter that is one dimension smaller. Reduces code size needed for zip_mut_with's fallback case (the inner rows stuff).

bluss added 6 commits March 29, 2017 22:54
@bluss
Add ixdyn bench
164d753
@bluss
Dimension: inline for IxDyn
b4945c5
@bluss
Add tests for Ix0
5aa7db1
@bluss
Add try_remove_axis to dimension
58fa2c9
@bluss
Add dimension-reduced versions of InnerIter
6f1c79b
@bluss
Use inner_iter_smaller in zip_mut_with
da78e30 
This dimension-reduces the inner iterators before we use them in zip,
which primarily reduces the code size for all the code outside the
innermost loop.

This should be a solid win by making the code size for all binary
operations smaller.
@bluss bluss merged commit 1923258 into master Mar 29, 2017
@bluss bluss deleted the try-smaller branch March 29, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluss