Skip to content

Conversation

emmatyping
Copy link
Contributor

Picking up from #1039 and based on my original implementation in #652 with the feedback from @bluss.

I found this implementation performs the same vs #1039 modulo using uninit, at least for my use case.

@emmatyping
Copy link
Contributor Author

Also I should mention that I kept the name as kron because that is what numpy and matlab use and it seems familiar.

@emmatyping
Copy link
Contributor Author

Hm, I just noticed there is also #690. Not sure what direction you want to go, but happy to work on getting an outer based implementation in if that's preferable.

Copy link
Member

@bluss bluss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have so much opinions about what's best here - this is outside my area.

It's easier if we maybe see it like this, some of the numerics stuff is not my area, and then it needs help from others to design and maybe even merge it, we maybe need a maintainer who likes that area. 🙂 I'm mainly focusing on certain things. It doesn't mean the other things are not good, just not my focus & interest.

@bluss bluss added this to the 0.15.4 milestone Nov 11, 2021
@bluss
Copy link
Member

bluss commented Nov 11, 2021

Thanks! Please keep this comment here in mind #1105 (review) - we need a maintainer for "this area" (deeper numerical functions) - also collaboration with the ndarray-linalg crate.

@bluss bluss merged commit 1c685ef into rust-ndarray:master Nov 11, 2021
@bluss bluss mentioned this pull request Nov 11, 2021
@emmatyping emmatyping deleted the kron branch November 11, 2021 23:34
@emmatyping
Copy link
Contributor Author

@bluss yes, I'd be happy to keep contributing and maintaining this area! I sent a message on matrix to follow up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants