-
Notifications
You must be signed in to change notification settings - Fork 90
Add new_draft
kind of labels in [autolabel]
#2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look! I wonder if we should just have some "label anti-matter", where we would say that label A is mutually exclusive with label B 😆
This will also set new draft PRs to be in the waiting on author status, I wonder if it won't be confusing to some people. Anyway, we'll see in practice as usually. This will need documentation in the Forge an a rustc PR, as usually.
I don't think it would necessarily help as removing a label (e.g. I say this as we have many exclusive labels around In any case let's merge this as I think it's useful even if we later add an exclusive mechanism. |
FWIW, I don't think it's possible to enforce exclusive labels, because can't you manually apply both labels at the same time? |
… r=Kobzol Auto-add `S-waiting-on-author` when the PR is/switches to draft state This PR adds the `S-waiting-on-author` as a `new_draft` when the PR is/switches to draft state. Related to rust-lang/triagebot#2102 & rust-lang/triagebot#2104 cc `@jieyouxu` r? `@Kobzol`
Rollup merge of #143695 - Urgau:waiting-on-author-new_draft, r=Kobzol Auto-add `S-waiting-on-author` when the PR is/switches to draft state This PR adds the `S-waiting-on-author` as a `new_draft` when the PR is/switches to draft state. Related to rust-lang/triagebot#2102 & rust-lang/triagebot#2104 cc `@jieyouxu` r? `@Kobzol`
Auto-add `S-waiting-on-author` when the PR is/switches to draft state This PR adds the `S-waiting-on-author` as a `new_draft` when the PR is/switches to draft state. Related to rust-lang/triagebot#2102 & rust-lang/triagebot#2104 cc `@jieyouxu` r? `@Kobzol`
This PR adds a new kind
new_draft
for labels in[autolabel]
, this is so that we can handleS-waiting-on-author
in a similar way toS-waiting-on-review
(ie add it when the PR is in draft state and remove it when it's not).Fixes #2102