Skip to content

Create a private channel that contains all team members #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2025
Merged

Create a private channel that contains all team members #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c13f5
Create a private channel that contains all team members
Kobzol Nov 17, 2025
e3c1ec7
Fix validation of Zulip streams
Kobzol Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,16 +758,20 @@ fn validate_zulip_stream_ids(data: &Data, errors: &mut Vec<String>) {
return Ok(());
}

wrapper(team.members(data)?.iter(), errors, |member, _| {
if let Some(member) = data.person(member) {
if member.zulip_id().is_none() {
bail!(
"person `{}` in '{}' is a member of a Zulip stream but has no Zulip id",
member.github(),
team.name()
);
wrapper(streams.iter(), errors, |stream, errors| {
wrapper(stream.members().iter(), errors, |member, _| {
match member {
ZulipMember::MemberWithId { .. } | ZulipMember::JustId(_) => {}
ZulipMember::MemberWithoutId { github } => {
bail!(
"person `{github}` is a member of a Zulip stream `{}` defined in team `{}`, but has no Zulip id",
stream.name(),
team.name()
);
}
}
}
Ok(())
});
Ok(())
});
Ok(())
Expand Down
14 changes: 14 additions & 0 deletions teams/all.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,17 @@ excluded-people = [
"celaus",
"opeolluwa",
]

# Private channel with all team members, so that we can have an easy way of reaching them.
[[zulip-streams]]
name = "all/private"
Copy link
Member

@tshepang tshepang Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be kool if this was named similar to the private one for leads

so we would have

  • project members (private)
  • project leads (private)

with this pr, we would have

  • all/private
  • project leads (private)

Copy link
Member Author

@Kobzol Kobzol Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are already a bunch of XXX/private channels, so the project leads one is an exception, I'd say, which was chosen because the channel already existed.

Copy link
Member

@tshepang tshepang Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, in that case (offtopic for this pr here), could it be renamed to leads/private to match others

Copy link
Member Author

@Kobzol Kobzol Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can automatically rename the channel through team, it would probably just create a new one. We'd have to do it by hand, but also sync it with team, so that it doesn't recreate a channel with the old name. So it's not trivial to rename.

# Exclude the following people from the Zulip stream for grandfathering purposes,
# where previously we didn't require all project team members to have Zulip IDs.
excluded-people = [
"U007D",
"andrewpollack",
"arshiamufti",
"bnchi",
"celaus",
"opeolluwa",
]