Skip to content

Conversation

@folkertdev
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2025

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn
Copy link
Contributor

sayantn commented Nov 17, 2025

It doesn't really matter when linking to LLVM intrinsics (LLVM only had i8, the signedness is determined by the operation). But we can do this just for the sake of our understanding. Will it be possible for you to check for other such inconsistencies? I believe there should be a lot more of them

@folkertdev
Copy link
Contributor Author

These I just found looking at rust-lang/miri#4705, I don't currently want to spend the time to look for more cases really.

@sayantn
Copy link
Contributor

sayantn commented Nov 17, 2025

Ok np, should I merge this then?

@folkertdev
Copy link
Contributor Author

Yes, if you think it looks good.

@sayantn sayantn added this pull request to the merge queue Nov 17, 2025
Merged via the queue into rust-lang:main with commit 50134e1 Nov 17, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants