Remove more Notification variants #4501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
notifications-2
branch
3 times, most recently
from
a4dd0a3 to
ed4ff46
Compare
rami3l
previously approved these changes
Sep 28, 2025
rami3l
dismissed
their stale review
Concerns regarding the output format change
djc
force-pushed
the
notifications-2
branch
from
ed4ff46 to
3245111
Compare
This messed with the tests, where my editor was chopping of trailing whitespace. While I'm in here, don't capitalize and parenthesize to make this line fit in better with the rest of our logging/errors.
rami3l
approved these changes
Oct 1, 2025
rami3l
reviewed
Oct 1, 2025
src/dist/manifestation.rs
Outdated
| &self.target_triple, | ||
| Some(&self.target_triple), | ||
| )); | ||
| info!(component = "rust", "installing component"); |
There was a problem hiding this comment.
This will be covered by #4471, not sure if it should be added back in that PR during rebase.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work started in