Skip to content

Some minor cleanup #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 21, 2019
Merged

Some minor cleanup #3970

merged 8 commits into from
Dec 21, 2019

Conversation

@tesuji
Copy link
Contributor

@tesuji tesuji commented Dec 18, 2019

No description provided.

topecongiro
topecongiro reviewed Dec 20, 2019
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Overall looks good to me. I will take another look within a few days, and merge this if I find no issues.

@topecongiro topecongiro merged commit a035b2c into rust-lang:master Dec 21, 2019
@tesuji tesuji deleted the slice branch December 21, 2019 15:34
@karyon
Copy link
Contributor

karyon commented Oct 28, 2021

backport not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@topecongiro topecongiro topecongiro left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1x-backport:n/a

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tesuji @karyon @topecongiro