update json emitter to better handle errors #3953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
approved these changes
Dec 9, 2019
Contributor
topecongiro
left a comment
topecongiro
left a comment
There was a problem hiding this comment.
LGTM, thank you! Also, I like that we now have a newline at the end of the output.
|
|
||
| #[test] | ||
| fn expected_line_range_correct_when_single_line_split() { | ||
| let mut emitter = JsonEmitter { |
Contributor
There was a problem hiding this comment.
Nit: we can use JsonEmitter::default().
Member
Author
There was a problem hiding this comment.
Good catch. I need to make a similar update to the checkstyle xml emitter at some point (which suffers from the same type of invalid output in this scenario) and will tweak this accordingly when I do
Member
Author
Me too. I feel like one day it would be good to see if we can also have the errors emitted as part of the json/xml output instead of stderr when the user specifies the |
karyon
pushed a commit
to karyon/rustfmt
that referenced
this pull request
Oct 28, 2021
calebcartwright
added a commit
that referenced
this pull request
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3952 and relevant for #3947
This changes the json emitter to emit the full json output for the formatting results as part of
emit_footerwhereas the current approach incrementally emitted incomplete json snippets as each file was processed and usedemit_headerandemit_footerto try to sandwich it all together into valid json (which was not always viable as described in #3952).