Rename CodeMap/FileMap to SourceMap/SourceFile #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAD97
commented
Aug 23, 2018
| // except according to those terms. | ||
|
|
||
| //! This module contains utilities that work with the `CodeMap` from `libsyntax` / `syntex_syntax`. | ||
| //! This module contains utilities that work with the `SourceMap` from `libsyntax`/`syntex_syntax`. |
There was a problem hiding this comment.
This line is the only one I had to manually address since the rename put it over 100 columns (to 101). I just removed the space around the / as a simple fix but honestly removing the reference to syntex might be the better "fix".
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2946
Surprisingly trivial find/replace worked here 🎉
Update to
rustc-ap@235, rust-lang/rust#52953