Skip to content

Update bitmaps to 3.2.1 #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Update bitmaps to 3.2.1 #2040

merged 2 commits into from
Apr 14, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Feb 11, 2025 •
edited
Loading

It's approximately 10-20% slower to compile on icounts and walltime:

time -p CARGO_INCREMENTAL=0 cargo check ; cargo clean
# 0,47
# 0.56

time -p CARGO_INCREMENTAL=0 cargo build ; cargo clean
# 0,50
# 0.62

time -p CARGO_INCREMENTAL=0 cargo build --release ; cargo clean
# 0,56
# 0.76

Related issue: #2024

@Kobzol Kobzol mentioned this pull request Feb 11, 2025
Closed
40 tasks
@Kobzol Kobzol marked this pull request as draft February 12, 2025 07:28
nnethercote
nnethercote approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kobzol Kobzol marked this pull request as ready for review April 14, 2025 09:34
@Kobzol Kobzol added the benchmark-update PR that updates the benchmark set. label Apr 14, 2025
@Kobzol Kobzol merged commit e3fcbeb into rust-lang:master Apr 14, 2025
11 checks passed
@Kobzol Kobzol changed the title [2025 benchmark update] Update bitmaps to 3.2.1 Update bitmaps to 3.2.1 Apr 14, 2025
@Kobzol Kobzol deleted the benchmark-2025-update-bitmaps branch April 14, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees
No one assigned
Labels
benchmark-update PR that updates the benchmark set.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @nnethercote