Skip to content

Add serde_derive-1.0.136 #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2022
Merged

Add serde_derive-1.0.136 #1306

merged 3 commits into from
Apr 22, 2022

Conversation

nnethercote
Copy link
Contributor

End-to-end build times:

check   3.3s
debug   5.5s
opt     7.0s

Final crate times:

Benchmark Profile Scenario % Change Significance Factor? Test Test
helloworld check full 0.00% - 0.23 0.23
helloworld debug full 0.00% - 0.24 0.24
helloworld opt full 0.00% - 0.218 0.218
serde_derive-1.0.136 check full 0.00% - 1.225 1.225
serde_derive-1.0.136 debug full 0.00% - 2.542 2.542
serde_derive-1.0.136 opt full 0.00% - 4.288 4.288

@nnethercote
Add serde_derive-1.0.136.
38c15b0 
Reasons to add:
- It's very widely used.
- It' a `proc-macro` crate (there are no other proc-macro crates in the
  primary benchmarks).
- It stresses declarative macro expansion a bit.
@nnethercote
Add test infrastructure for serde_derive-1.0.136.
423f578
@nnethercote
Assorted minor documentation improvements.
0c00c74
@nnethercote nnethercote requested a review from lqd April 22, 2022 06:06
lqd
lqd approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to have at least a proc-macro in the primary benchmarks.

The doc changes look good as well.

@nnethercote nnethercote merged commit 5a14ec4 into rust-lang:master Apr 22, 2022
@nnethercote nnethercote deleted the add-serde_derive branch April 22, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnethercote @lqd