Skip to content

Conversation

@rchaser53
Copy link
Contributor

@rchaser53 rchaser53 commented Jan 19, 2019

related: rust-lang/rust#57469

fix variable name like below

  • Value => ConstValue
  • PrimVal => Scalar
  • Value::ByVal => ConstValue::Scalar
  • Value::ByValPair => ConstValue::ScalarPair

rename variables like below
 - Value => ConstValue
 - PrimVal => Scalar
 - Value::ByVal => ConstValue::Scalar
 - Value::ByValPair => ConstValue::ScalarPair
@rchaser53
Copy link
Contributor Author

this is the first PR to rustc-guide for me, so i anxious about this pr.
the ci is failed, but i just replaced the words. i guess my commit isn't related the ci failed.
should i need to fix something?

@oli-obk
Copy link
Contributor

oli-obk commented Jan 21, 2019

Cycling CI (the failure seems to be a network timeout)

@oli-obk oli-obk closed this Jan 21, 2019
@oli-obk oli-obk reopened this Jan 21, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Jan 21, 2019

Oh, must be something else. I opened #265 to track that travis failure.

Thanks for keeping the guide up to date!

@oli-obk oli-obk merged commit 3f3285b into rust-lang:master Jan 21, 2019
@rchaser53 rchaser53 deleted the rename-variables-related-miri branch January 21, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants