Skip to content

Conversation

csmoe
Copy link
Contributor

@csmoe csmoe commented Jul 28, 2022

Closes #99788

Link arg -no_dead_strip doesn't exist on OSX at all.
The no_gc_sections function was never called before export-executable-symols implementation, and export-executable-symbols still works, so we just remove it.
r? @bjorn3

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2022
@bjorn3
Copy link
Member

bjorn3 commented Jul 28, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 28, 2022

📌 Commit 03f9efe has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#99628 (add more docs regarding ideographic numbers)
 - rust-lang#99689 (Revert `write!` and `writeln!` to late drop temporaries)
 - rust-lang#99807 (Fix PermissionDenied UI tests on WSL)
 - rust-lang#99817 (rustdoc: remove Clean trait impls for more items)
 - rust-lang#99851 (Fix small typo in Cargo.toml comment)
 - rust-lang#99856 (fix: remove fake no_dead_strip for osx)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 55f041e into rust-lang:master Jul 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-no_dead_strip cannot be recognized by ld on osx
5 participants