add suggestion when there is a impl of external trait on pointer with wrong coherence rules #99686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
vincenzopalazzo
commented
Jul 24, 2022
vincenzopalazzo
force-pushed
the
macros/impl_on_ptr
branch
from
9afda22 to
78f2bc4
Compare
vincenzopalazzo
changed the title
vincenzopalazzo
force-pushed
the
macros/impl_on_ptr
branch
from
78f2bc4 to
e1d1fa9
Compare
vincenzopalazzo
force-pushed
the
macros/impl_on_ptr
branch
2 times, most recently
from
119d42a to
07de5de
Compare
vincenzopalazzo
force-pushed
the
macros/impl_on_ptr
branch
2 times, most recently
from
ddf4d0c to
e566a33
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/impl_on_ptr
branch
from
e566a33 to
1e584d2
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99686 (add suggestion when there is a impl of external trait on pointer with wrong coherence rules) - rust-lang#99760 (doc/rustc: describe the uefi target platforms) - rust-lang#99766 (Htmldocck: Substitute the doc channel when blessing) - rust-lang#99781 (Use String::from_utf8_lossy in CStr demo) - rust-lang#99803 (Update mentions to `rustc_metadata::rmeta::Lazy`) - rust-lang#99845 (Remove `$` prefix for bash scripts in doc) - rust-lang#99850 (rustdoc: Remove more Clean trait implementations) - rust-lang#99872 (Clone the `src/llvm-project` submodule if profiling is enabled) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99572
This will try to improve the node in the error message by suggesting a general solution because the solution, in this case, is application depended.
I'm not super happy regarding the code quality, but I'm happy to have feedback on it.
@rustbot r? @compiler-errors