Skip to content

Refactor path segment parameter error #98119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2022
Merged

Refactor path segment parameter error #98119

merged 1 commit into from
Jun 16, 2022

Conversation

EdwinRy
Copy link
Contributor

@EdwinRy EdwinRy commented Jun 15, 2022

This PR attempts to rewrite the error handling for an unexpected parenthesised type parameters to:

  • Use provided data instead of re-parsing the whole span
  • Add a multipart suggestion to reflect on the changes with an underline
  • Remove the unnecessary "if" nesting

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 15, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2022
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 15, 2022

📌 Commit 71a98e1 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2022
@JohnTitor JohnTitor mentioned this pull request Jun 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2022
@bors
Auto merge of rust-lang#98152 - JohnTitor:rollup-osr17j6, r=JohnTitor
5bc82c0 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#97202 (os str capacity documentation)
 - rust-lang#97964 (Fix suggestions for `&a: T` parameters)
 - rust-lang#98053 (Fix generic impl rustdoc json output)
 - rust-lang#98059 (Inline `const_eval_select`)
 - rust-lang#98092 (Fix sidebar items expand collapse)
 - rust-lang#98119 (Refactor path segment parameter error)
 - rust-lang#98135 (Add regression test for rust-lang#93775)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfc6c90 into rust-lang:master Jun 16, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EdwinRy @rust-highfive @estebank @bors @rustbot