Skip to content

Try out yeet in the MIR interpreter #98018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2022
Merged

Try out yeet in the MIR interpreter #98018

merged 1 commit into from
Jun 12, 2022

Conversation

scottmcm
Copy link
Member

Since we got a new bootstrap, we can give this a shot.

r? @oli-obk

@rust-highfive
Copy link
Contributor

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 12, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2022
@RalfJung
Copy link
Member

LGTM. :)
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

📌 Commit a6c6fa0 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2022
@bors
Copy link
Collaborator

bors commented Jun 12, 2022

⌛ Testing commit a6c6fa0 with merge 546c826...

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 546c826 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 12, 2022
@bors bors merged commit 546c826 into rust-lang:master Jun 12, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 12, 2022
@rust-highfive rust-highfive mentioned this pull request Jun 12, 2022
Closed
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #98018!

Tested on commit 546c826.
Direct link to PR: #98018

💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 12, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#98018!
5449df2 
Tested on commit rust-lang/rust@546c826.
Direct link to PR: <rust-lang/rust#98018>

💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).
@scottmcm scottmcm deleted the miri-yeet branch June 13, 2022 00:10
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (546c826): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 1.1% 1.1% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -0.6% -0.6% 1
All 😿🎉 (primary) 1.1% 1.1% 1

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.9% 2.9% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@scottmcm @rust-highfive @RalfJung @bors @rust-timer @oli-obk @rustbot