Rollup of 7 pull requests #97783
Merged
Rollup of 7 pull requests #97783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Goulet <[email protected]>
…=jsha Add empty impl blocks if they have documentation Fixes rust-lang#90866. The update for the test script is needed to count the number of impl blocks we have with only the struct. To be noted that with rust-lang#89676 merged, it wouldn't be needed (I don't know what is the status of it btw. cc ```@Mark-Simulacrum).``` It looks like this:  cc ```@jyn514``` r? ```@camelid```
Fail gracefully when encountering an HRTB in APIT. Fixes rust-lang#96954 ~The first commit will be merged as part of rust-lang#97415
…h726 Do `suggest_await_before_try` with infer variables in self, and clean up binders Fixes rust-lang#97704 Also cleans up binders in this fn, since everything is a `Poly*` and we really shouldn't have stray escaping late-bound regions everywhere. That's why the function changed so much. This isn't necessary, so I can revert if necessary.
typo: `-Zcodegen-backend=llvm -Cpasses=list` should work now r? ```@bjorn3```
…compiler-errors
Suggest adding `{}` for `'label: non_block_expr`
Adds suggestions like this:
```text
help: consider enclosing expression in a block
|
3 | 'l {0};
| + +
```
inspired by rust-lang#48594 (comment)
r? ``@compiler-errors``
use strict provenance APIs The stdlib was adjusted to avoid bare int2ptr casts, but recently some casts of that sort have sneaked back in. Let's fix that. :)
…crum Restore a test that was intended to test `as` cast to ptr This test was changed in rust-lang#61864, but the original bug rust-lang#46365 was about casts so I doubt the changed test still even tests what this was intended to test. Let's restore the original test.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
|
📌 Commit 1258fa9 has been approved by |
bors
added
the
S-waiting-on-bors
|
there's already another rollup in progress - #97781 |
|
(no worries i'll close that one) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
mh spurious error that has shown up in other PRs as well |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 1258fa9 has been approved by |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (e70c60d): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
suggest_await_before_trywith infer variables in self, and clean up binders #97721 (Dosuggest_await_before_trywith infer variables in self, and clean up binders)-Zcodegen-backend=llvm -Cpasses=listshould work now #97752 (typo:-Zcodegen-backend=llvm -Cpasses=listshould work now){}for'label: non_block_expr#97759 (Suggest adding{}for'label: non_block_expr)ascast to ptr #97765 (Restore a test that was intended to testascast to ptr)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup