Skip to content

Conversation

xFrednet
Copy link
Contributor

@xFrednet xFrednet commented Jun 3, 2022

A small PR to allow the #[expect] attribute on function parameters.

Nothing more to say, I hope everyone reading this has a lovely day.


r? @wesleywiser

closes: #97650

cc: #85549

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 3, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2022
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! r=me with blessed tests

@xFrednet
Copy link
Contributor Author

xFrednet commented Jun 3, 2022

Will do, thank you for the quick review!

@xFrednet xFrednet force-pushed the 97650-expect-in-fuction-arg branch from b7d7c0e to b5eee17 Compare June 3, 2022 22:50
@xFrednet
Copy link
Contributor Author

xFrednet commented Jun 3, 2022

Waiting for the CI until the r= 🙃

@xFrednet
Copy link
Contributor Author

xFrednet commented Jun 3, 2022

@bors r=wesleywiser

@bors
Copy link
Collaborator

bors commented Jun 3, 2022

📌 Commit b5eee17 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2022
@xFrednet
Copy link
Contributor Author

xFrednet commented Jun 3, 2022

Ups wrong comment. It should be

@bors rollup=always

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 4, 2022
…g, r=wesleywiser

Support the `#[expect]` attribute on fn parameters (RFC-2383)

A small PR to allow the `#[expect]` attribute on function parameters.

Nothing more to say, I hope everyone reading this has a lovely day.

---

r? `@wesleywiser`

closes: rust-lang#97650

cc: rust-lang#85549
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#96642 (Avoid zero-sized allocs in ThinBox if T and H are both ZSTs.)
 - rust-lang#97647 (Lazily allocate and initialize pthread locks.)
 - rust-lang#97715 (Support the `#[expect]` attribute on fn parameters (RFC-2383))
 - rust-lang#97716 (Fix reachability analysis for const methods)
 - rust-lang#97722 (Tighten spans for bad fields in struct deriving `Copy`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c794b4 into rust-lang:master Jun 4, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 4, 2022
@xFrednet xFrednet deleted the 97650-expect-in-fuction-arg branch June 4, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[expect(..)] not supported on function arguments
6 participants