Updates to browser-ui-test #97354
Merged
Updates to browser-ui-test #97354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit d4d1e23 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2022
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#96033 (Add section on common message styles for Result::expect) - rust-lang#97354 (Updates to browser-ui-test) - rust-lang#97424 (clippy::complexity fixes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the commits from #97317. Since the ubuntu 22.04 version, you either need to use
--no-sandboxor use another binary to run the GUI tests. I couldn't find out why the chromium used bybrowser-ui-testisn't working anymore on this ubuntu version.r? @notriddle