testsuite: Two tests for fixed bugs #9733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexcrichton Any guesses as to what's going on here? The only non-test change I made was to the unreachable code lint... |
Member
|
Looks like it error'd out before reaching the lint pass so the lint warnings wasn't printed just yet. I think it's safe to just remove the warning expectation from the test about unreachable code. |
Contributor
Author
|
@alexcrichton Ah, ok. Didn't occur to me that that lint change could have caused another test to fail, but of course. facepalm |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
Ensure new_ret_no_self is not fired if impl Trait<Self> is returned. Fix rust-lang#7344: ensure new_ret_no_self is not fired if `impl Trait<Self>` is returned. changelog: [`new_ret_no_self`]: No longer lints when `impl Trait<Self>` is returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? anybody Closes #7246
Closes #7573