Fix settings page CSS #96939
Merged
Fix settings page CSS #96939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit dd6bb09 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#95896 (Note the contacts for the nvptx64 target(s)) - rust-lang#96860 (openbsd: convert futex timeout managment to Timespec usage) - rust-lang#96939 (Fix settings page CSS) - rust-lang#96941 (update graphviz links) - rust-lang#96968 (Add tests for rust-lang#96806) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #96741, I moved the CSS loading outside of
settings.js. The result was that on the settings page, there isn't the settings CSS anymore:I also used this opportunity to remove unused CSS rules (we don't have
<select>elements anymore in the settings).cc @jsha
r? @notriddle