Move callback to the () => {} syntax. #96658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #96663) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
May 3, 2022
|
Looks good to me! Please squash your commits (take a look here if you don't know how) and then I'll approve it. |
Fix lint Fix main.js Restore anonymous functions Fix Fix more
Squash done. Thanks, @GuillaumeGomez. 👍 |
GuillaumeGomez
approved these changes
May 4, 2022
|
Thanks! @bors: r+ rollup |
|
📌 Commit 67ebeea has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#96603 (Enable full revision in const generics ui tests) - rust-lang#96616 (Relax memory ordering used in `min_stack`) - rust-lang#96619 (Relax memory ordering used in SameMutexCheck) - rust-lang#96628 (Stabilize `bool::then_some`) - rust-lang#96658 (Move callback to the () => {} syntax.) - rust-lang#96677 (Add more tests for label-break-value) - rust-lang#96697 (Enable tracing for all queries) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #93058.
r? @GuillaumeGomez