Skip to content

Conversation

Gumichocopengin8
Copy link
Contributor

@Gumichocopengin8 Gumichocopengin8 commented Apr 14, 2022

Update actions/checkout@v2 to actions/checkout@v3 because of Node12 will be out of life after Aril 30, 2022 [Reference].
actions/xxxx@v3 use Node16 whose support lasts until April 30, 2024.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2022
@Gumichocopengin8 Gumichocopengin8 changed the title Update GitHub Actions actions/checkout Version Update GitHub Actions actions/checkout Version v2 -> v3 Apr 14, 2022
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 14, 2022
@pietroalbini
Copy link
Member

r? @pietroalbini (assigning this to me)

Hi, and thanks for the PR!

Could you limit this PR only to changing the .github/workflows and the src/ci/github-actions directories? The other files you changed are in subtrees (imports of other repositories), and those changes should be made to those repositories directly.

@pietroalbini pietroalbini added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2022
@Gumichocopengin8
Copy link
Contributor Author

@pietroalbini Thanks for reviewing. I'll fix it.

update: actions/checkout@v2 to actions/checkout@v3 for all yaml files

Revert "update: actions/checkout@v2 to actions/checkout@v3 for all yaml files"

This reverts commit 7445e582b900f0f56f5f2bd9036aacab97ef28e9.

change GitHub Actions version v2 to v3

change GitHub Actions
@Gumichocopengin8 Gumichocopengin8 force-pushed the feature/update-github-action-version branch from 19a15f2 to 9d319f3 Compare April 14, 2022 20:21
@Gumichocopengin8
Copy link
Contributor Author

Could you limit this PR only to changing the .github/workflows and the src/ci/github-actions directories? The other files you changed are in subtrees (imports of other repositories), and those changes should be made to those repositories directly.

Changed only github/workflows and the src/ci/github-actions directories.

@pietroalbini
Copy link
Member

Great, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 14, 2022

📌 Commit 9d319f3 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2022
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Apr 15, 2022
…hub-action-version, r=pietroalbini

Update GitHub Actions actions/checkout Version v2 -> v3

Update `actions/checkout@v2` to `actions/checkout@v3` because of Node12 will be out of life after Aril 30, 2022 [[Reference](https://nodejs.org/en/about/releases/)].
`actions/xxxx@v3` use Node16 whose support lasts until April 30, 2024.
RalfJung added a commit to RalfJung/rust that referenced this pull request Apr 15, 2022
…hub-action-version, r=pietroalbini

Update GitHub Actions actions/checkout Version v2 -> v3

Update `actions/checkout@v2` to `actions/checkout@v3` because of Node12 will be out of life after Aril 30, 2022 [[Reference](https://nodejs.org/en/about/releases/)].
`actions/xxxx@v3` use Node16 whose support lasts until April 30, 2024.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 15, 2022
…hub-action-version, r=pietroalbini

Update GitHub Actions actions/checkout Version v2 -> v3

Update `actions/checkout@v2` to `actions/checkout@v3` because of Node12 will be out of life after Aril 30, 2022 [[Reference](https://nodejs.org/en/about/releases/)].
`actions/xxxx@v3` use Node16 whose support lasts until April 30, 2024.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 16, 2022
…hub-action-version, r=pietroalbini

Update GitHub Actions actions/checkout Version v2 -> v3

Update `actions/checkout@v2` to `actions/checkout@v3` because of Node12 will be out of life after Aril 30, 2022 [[Reference](https://nodejs.org/en/about/releases/)].
`actions/xxxx@v3` use Node16 whose support lasts until April 30, 2024.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#95887 (resolve: Create dummy bindings for all unresolved imports)
 - rust-lang#96023 (couple of clippy::perf fixes)
 - rust-lang#96035 (Update GitHub Actions actions/checkout Version v2 -> v3)
 - rust-lang#96038 (docs: add link from zip to unzip)
 - rust-lang#96047 (:arrow_up: rust-analyzer)
 - rust-lang#96059 (clarify doc(cfg) wording)
 - rust-lang#96081 (Make some `usize`-typed masks definitions agnostic to the size of `usize`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ce30f5c into rust-lang:master Apr 16, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 16, 2022
@Gumichocopengin8 Gumichocopengin8 deleted the feature/update-github-action-version branch April 16, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants